Make tiles display at the same physical size regardless of pixel dens…#2248
Merged
rborn merged 3 commits intoreact-native-maps:masterfrom May 13, 2018
funkyfourier:master
Merged
Make tiles display at the same physical size regardless of pixel dens…#2248rborn merged 3 commits intoreact-native-maps:masterfrom funkyfourier:master
rborn merged 3 commits intoreact-native-maps:masterfrom
funkyfourier:master
Conversation
Collaborator
|
LGTM @alvelig |
Contributor
|
LGTM |
timxyz
pushed a commit
to 3sidedcube/react-native-maps
that referenced
this pull request
Aug 24, 2018
* master: (168 commits) Adding overlaying components details (react-native-maps#2425) docs: pin color limitations for android (react-native-maps#2429) Revert "Added MBTiles support for iOS and Android (react-native-maps#2208)" (react-native-maps#2387) Added MBTiles support for iOS and Android (react-native-maps#2208) Fix disabling the toolbar and my location button (react-native-maps#2317) Fixes warnings about self (react-native-maps#2341) Android: Fix lineCap of Polyline (react-native-maps#2375) Update installation.md (react-native-maps#2381) update doc (react-native-maps#2363) zIndex doesn't work when the map moves in iOS 11 (react-native-maps#2359) Fix readme formatting (react-native-maps#2358) add support for calloutAnchor with GoogleMaps on iOS; fixes react-native-maps#1852 (react-native-maps#2351) Added animateToNavigation method to MapView (react-native-maps#2049) Add react-native@^0.55 to peerDependencies (react-native-maps#2332) Fix custom marker updates on android react-native-maps#1611 react-native-maps#2048 [iOS] Prefix or eliminate globals in AIRMapMarker (react-native-maps#2306) Fix CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warnings (react-native-maps#2154) Fix for compile error (react-native-maps#2215). (react-native-maps#2232) Make tiles display at the same physical size regardless of pixel dens… (react-native-maps#2248) Added support of lineDashPattern polyline prop to iOS Google Maps (react-native-maps#2243) ... # Conflicts: # lib/components/MapMarker.js
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
react-native-maps#2248) * Make tiles display at the same physical size regardless of pixel density on iOS devices * Fix for timestamp issue * Removed plus sign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ity on iOS devices
Does any other open PR do the same thing?
Not that I know of.
What issue is this PR fixing?
#2242
How did you test this PR?
This makes UrlTile, when using Google Maps API, behave the same way on iOS as it currently does on Android. That is, displaying tiles at the same physical size regardless of pixel density.
Have tested on simulators iPhone X and iPhone 6, as well as a physical iPhone 5S device.
Here is a snack, which should also work without Expo: https://snack.expo.io/@jmr/urltile-ios-tile-size
Without my modification it will display the tiles very tiny on high dpi devices, and with the modification it will display them at the same size regardless.