Skip to content

Fix Xcode warnings for format, pointer type, unused var#2185

Merged
brentvatne merged 1 commit intoreact-native-maps:masterfrom
expo:@terribleben/fix-warnings
Apr 16, 2018
Merged

Fix Xcode warnings for format, pointer type, unused var#2185
brentvatne merged 1 commit intoreact-native-maps:masterfrom
expo:@terribleben/fix-warnings

Conversation

@terribleben
Copy link
Contributor

We noticed these warnings when using this library inside Expo. Changed NULL to 0 for the NSStringCompareOptions flag; cast the NSIntegers to long when using as a string format argument; removed unused variable zoomLevel.

Does any other open PR do the same thing?

Not as far as I can tell.

What issue is this PR fixing?

There are some annoying compiler warnings in Xcode and this makes them go away.

How did you test this PR?

I compiled the lib.

We noticed these warnings when using this library inside Expo. Changed NULL to 0 for the NSStringCompareOptions flag; cast the NSIntegers to long when using as a string format argument; removed unused variable zoomLevel.
@brentvatne brentvatne merged commit 6086621 into react-native-maps:master Apr 16, 2018
@terribleben terribleben deleted the @terribleben/fix-warnings branch April 16, 2018 21:30
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
…warnings

Fix Xcode warnings for format, pointer type, unused var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants