Fix compile issues in Android (; expected and cannot find symbol)#2184
Merged
rborn merged 1 commit intoreact-native-maps:masterfrom Apr 18, 2018
Merged
Conversation
Contributor
Author
|
ping @rborn and @akmjenkins, maybe you can check if the |
Contributor
|
@jerolimov How embarrassing, a bunch of things about my previous PR went wrong. Thanks for catching this! I forgot that in Android there are default values specified for minimumZ and maximumZ so do we need the check to see if it's greater than 0 in there at all? |
|
Hi, please merge this PR because master is not compiling in Android since 8 days ago! |
Collaborator
|
@pedrolopes10 can you confirm you tested this PR and it compiles ok ? |
Contributor
Author
|
Checkout the diff. It works and it fixes only obvious syntax errors.. 😉 |
|
@rborn sorry about the delay, yes I can confirm that it works fine. Thanks for the merge and the great work! |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
Fixing a compile issue of the Android version. I did not understand exactly what the (merged) PR #2136 does, but it breaks the Android java build with this error(s):
How did you test this PR?
yarn upgrade react-native-maps@react-community/react-native-maps#master)react-native run-android