Fix initialRegion when using RN 0.54#2131
Merged
rborn merged 2 commits intoreact-native-maps:masterfrom Mar 28, 2018
Merged
Conversation
…dow rather than when the map is ready
Collaborator
|
@lachenmayer how does this influence the lower versions of RN ? |
Contributor
|
AFAIK, this'll work fine in previous versions too. I tested it with RN 0.52 and 0.54, both worked fine. |
MichielDeMey
added a commit
to MichielDeMey/react-native-maps
that referenced
this pull request
Mar 29, 2018
Fix initialRegion when using RN 0.54 (react-native-maps#2131)
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
* Fix initialRegion being zoomed out as described in react-native-maps#2100 * Start ignoring setInitialRegion calls once the map view is in the window rather than when the map is ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2100 for discussion.