permit android vector drawables to be used as markers#2111
Merged
rborn merged 1 commit intoreact-native-maps:masterfrom Mar 22, 2018
Merged
permit android vector drawables to be used as markers#2111rborn merged 1 commit intoreact-native-maps:masterfrom
rborn merged 1 commit intoreact-native-maps:masterfrom
Conversation
Contributor
|
LGTM @rborn 🐽 |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
How did you test this PR?
On Android, add a vector drawable resource to the native code. (Here is a sample if you need one.) Then, try to use it as the {{marker}} parameter. Previously, an exception would be thrown; with this PR, it now works: