Check for presence of project-wide gradle configuration properties#2047
Merged
rborn merged 1 commit intoreact-native-maps:masterfrom Mar 5, 2018
transistorsoft:add-gradle-properties
Merged
Check for presence of project-wide gradle configuration properties#2047rborn merged 1 commit intoreact-native-maps:masterfrom transistorsoft:add-gradle-properties
rborn merged 1 commit intoreact-native-maps:masterfrom
transistorsoft:add-gradle-properties
Conversation
…mpileSdkVersion, buildToolsVersion, targetSdkVersion, androidMapsUtilsVersion. This provides a much better mechanism for aligning the module to the host project, particularly for play-services version
Collaborator
|
LGTM @christocracy thanks for the PR ❤️ |
Contributor
|
Oh, I get it! Yes that's a great thing |
This was referenced Mar 20, 2018
Contributor
Author
|
Seems this was a timely addition with the big play-services 12.0.0 blow-up today ;) |
This was referenced Apr 21, 2018
Merged
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…mpileSdkVersion, buildToolsVersion, targetSdkVersion, androidMapsUtilsVersion. This provides a much better mechanism for aligning the module to the host project, particularly for play-services version (react-native-maps#2047)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recommended by the Android Developer Document Gradle Tips & Tricks (See "Configure project-wide properties"), if the hosting application defines the following properties in their root
build.gradle, peer modules (likereact-native-maps) can align its dependencies as requested:📂
android/build.gradlebuildscript {...} allprojects {...} /** * Project-wide gradle configuration properties for use by all modules */ +ext { + compileSdkVersion = 26 + targetSdkVersion = 26 + buildToolsVersion = "26.0.2" + supportLibVersion = "26.1.0" + googlePlayServicesVersion = "11.8.0" + androidMapsUtilsVersion = "0.5+" +}📂
android/app/build.gradleandroid { + compileSdkVersion rootProject.compileSdkVersion + buildToolsVersion rootProject.buildToolsVersion defaultConfig { + targetSdkVersion rootProject.targetSdkVersion } } dependencies { compile fileTree(dir: "libs", include: ["*.jar"]) + compile "com.android.support:appcompat-v7:$rootProject.supportLibVersion" compile "com.facebook.react:react-native:+" // From node_modules compile project(':react-native-background-geolocation') compile project(':react-native-background-fetch') compile project(':react-native-device-info') compile project(':react-native-maps') }This provides a much better mechanism for aligning
play-servicesversion than all the nasty business ofexclude group:Many other modules are beginning to implement this project-wide configuration properties mechansism, eg:
react-native-background-geolocationreact-native-background-fetchreact-native-device-inforeact-native-firebase