Skip to content

Commit 445550d

Browse files
author
Titani
committed
updates from comments
1 parent f854bb4 commit 445550d

File tree

2 files changed

+44
-30
lines changed

2 files changed

+44
-30
lines changed

packages/react-core/src/components/OverflowMenu/examples/OverflowMenu.md

Lines changed: 43 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ propComponents:
99
'OverflowMenuControl',
1010
'OverflowMenuDropdownItem',
1111
'OverflowMenuGroup',
12-
'OverflowMenuItem',
12+
'OverflowMenuItem'
1313
]
1414
---
1515

@@ -48,7 +48,7 @@ class SimpleOverflowMenu extends React.Component {
4848
isOpen: !this.state.isOpen
4949
});
5050
};
51-
this.onSelect = event => {
51+
this.onSelect = (event) => {
5252
this.setState({
5353
isOpen: !this.state.isOpen
5454
});
@@ -88,7 +88,7 @@ class SimpleOverflowMenu extends React.Component {
8888
<OverflowMenuControl>
8989
<DropdownNext
9090
onSelect={this.onSelect}
91-
toggle={toggleRef => (
91+
toggle={(toggleRef) => (
9292
<MenuToggle
9393
ref={toggleRef}
9494
aria-label="Simple example overflow menu"
@@ -100,12 +100,14 @@ class SimpleOverflowMenu extends React.Component {
100100
</MenuToggle>
101101
)}
102102
isOpen={isOpen}
103-
onOpenChange={isOpen => setIsOpen(isOpen)}
103+
onOpenChange={(isOpen) =>
104+
this.setState({
105+
isOpen
106+
})
107+
}
104108
>
105-
<DropdownList>
106-
{dropdownItems}
107-
</DropdownList>
108-
</DropdownNext>
109+
<DropdownList>{dropdownItems}</DropdownList>
110+
</DropdownNext>
109111
</OverflowMenuControl>
110112
</OverflowMenu>
111113
);
@@ -145,7 +147,7 @@ class OverflowMenuGroupTypes extends React.Component {
145147
isOpen: !this.state.isOpen
146148
});
147149
};
148-
this.onSelect = event => {
150+
this.onSelect = (event) => {
149151
this.setState({
150152
isOpen: !this.state.isOpen
151153
});
@@ -223,7 +225,7 @@ class OverflowMenuGroupTypes extends React.Component {
223225
<OverflowMenuControl>
224226
<DropdownNext
225227
onSelect={this.onSelect}
226-
toggle={toggleRef => (
228+
toggle={(toggleRef) => (
227229
<MenuToggle
228230
ref={toggleRef}
229231
aria-label="Group example overflow menu"
@@ -235,12 +237,14 @@ class OverflowMenuGroupTypes extends React.Component {
235237
</MenuToggle>
236238
)}
237239
isOpen={isOpen}
238-
onOpenChange={isOpen => setIsOpen(isOpen)}
240+
onOpenChange={(isOpen) =>
241+
this.setState({
242+
isOpen
243+
})
244+
}
239245
>
240-
<DropdownList>
241-
{dropdownItems}
242-
</DropdownList>
243-
</DropdownNext>
246+
<DropdownList>{dropdownItems}</DropdownList>
247+
</DropdownNext>
244248
</OverflowMenuControl>
245249
</OverflowMenu>
246250
);
@@ -280,7 +284,7 @@ class OverflowMenuAdditionalOptions extends React.Component {
280284
isOpen: !this.state.isOpen
281285
});
282286
};
283-
this.onSelect = event => {
287+
this.onSelect = (event) => {
284288
this.setState({
285289
isOpen: !this.state.isOpen
286290
});
@@ -308,7 +312,9 @@ class OverflowMenuAdditionalOptions extends React.Component {
308312
<OverflowMenuDropdownItem itemId={5} key="6" isShared>
309313
Action 6
310314
</OverflowMenuDropdownItem>,
311-
<OverflowMenuDropdownItem itemId={6} key="7">Action 7</OverflowMenuDropdownItem>
315+
<OverflowMenuDropdownItem itemId={6} key="7">
316+
Action 7
317+
</OverflowMenuDropdownItem>
312318
];
313319
return (
314320
<OverflowMenu breakpoint="lg">
@@ -345,7 +351,7 @@ class OverflowMenuAdditionalOptions extends React.Component {
345351
<OverflowMenuControl hasAdditionalOptions>
346352
<DropdownNext
347353
onSelect={this.onSelect}
348-
toggle={toggleRef => (
354+
toggle={(toggleRef) => (
349355
<MenuToggle
350356
ref={toggleRef}
351357
aria-label="Multiple group example overflow menu"
@@ -357,12 +363,14 @@ class OverflowMenuAdditionalOptions extends React.Component {
357363
</MenuToggle>
358364
)}
359365
isOpen={isOpen}
360-
onOpenChange={isOpen => setIsOpen(isOpen)}
366+
onOpenChange={(isOpen) =>
367+
this.setState({
368+
isOpen
369+
})
370+
}
361371
>
362-
<DropdownList>
363-
{dropdownItems}
364-
</DropdownList>
365-
</DropdownNext>
372+
<DropdownList>{dropdownItems}</DropdownList>
373+
</DropdownNext>
366374
</OverflowMenuControl>
367375
</OverflowMenu>
368376
);
@@ -415,7 +423,9 @@ class OverflowMenuPersist extends React.Component {
415423
<OverflowMenuDropdownItem itemId={1} key="tertiary" isShared>
416424
Tertiary
417425
</OverflowMenuDropdownItem>,
418-
<OverflowMenuDropdownItem itemId={2} key="action">Action 4</OverflowMenuDropdownItem>
426+
<OverflowMenuDropdownItem itemId={2} key="action">
427+
Action 4
428+
</OverflowMenuDropdownItem>
419429
];
420430
return (
421431
<OverflowMenu breakpoint="lg">
@@ -435,7 +445,7 @@ class OverflowMenuPersist extends React.Component {
435445
<OverflowMenuControl hasAdditionalOptions>
436446
<DropdownNext
437447
onSelect={this.onSelect}
438-
toggle={toggleRef => (
448+
toggle={(toggleRef) => (
439449
<MenuToggle
440450
ref={toggleRef}
441451
aria-label="Persistent example overflow menu"
@@ -447,12 +457,14 @@ class OverflowMenuPersist extends React.Component {
447457
</MenuToggle>
448458
)}
449459
isOpen={isOpen}
450-
onOpenChange={isOpen => setIsOpen(isOpen)}
460+
onOpenChange={(isOpen) =>
461+
this.setState({
462+
isOpen
463+
})
464+
}
451465
>
452-
<DropdownList>
453-
{dropdownItems}
454-
</DropdownList>
455-
</DropdownNext>
466+
<DropdownList>{dropdownItems}</DropdownList>
467+
</DropdownNext>
456468
</OverflowMenuControl>
457469
</OverflowMenu>
458470
);
@@ -467,4 +479,5 @@ By passing in the `breakpointReference` property, the overflow menu's breakpoint
467479
You can change the container width in this example by adjusting the slider. As the container width changes, the overflow menu will change between a horizontal menu and a vertical dropdown despite the viewport width not changing.
468480

469481
```ts file="./OverflowMenuBreakpointOnContainer.tsx"
482+
470483
```

packages/react-core/src/components/OverflowMenu/examples/OverflowMenuBreakpointOnContainer.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ export const OverflowMenuBreakpointOnContainer: React.FunctionComponent = () =>
9898
</MenuToggle>
9999
)}
100100
isOpen={isOpen}
101+
onOpenChange={isOpen => setIsOpen(isOpen)}
101102
>
102103
<DropdownList>{dropdownItems}</DropdownList>
103104
</Dropdown>

0 commit comments

Comments
 (0)