From 44e5ed4b51dc4b8bb466c3006da4b46bad90b4c1 Mon Sep 17 00:00:00 2001 From: Denys Date: Thu, 19 Mar 2026 22:48:47 +0000 Subject: [PATCH 1/2] fix(i18n): missing number formatting --- app/components/Package/TableRow.vue | 11 +++-------- app/components/PaginationControls.vue | 4 ++-- app/pages/search.vue | 2 +- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/app/components/Package/TableRow.vue b/app/components/Package/TableRow.vue index 06b6ec5388..a79939658c 100644 --- a/app/components/Package/TableRow.vue +++ b/app/components/Package/TableRow.vue @@ -22,13 +22,6 @@ const isSelected = computed(() => { return isPackageSelected(props.result.package.name) }) -function formatDownloads(count?: number): string { - if (count === undefined) return '-' - if (count >= 1_000_000) return `${(count / 1_000_000).toFixed(1)}M` - if (count >= 1_000) return `${(count / 1_000).toFixed(1)}K` - return count.toString() -} - function formatScore(value?: number): string { if (value === undefined || value === 0) return '-' return Math.round(value * 100).toString() @@ -44,6 +37,8 @@ const allMaintainersText = computed(() => { if (!pkg.value.maintainers?.length) return '' return pkg.value.maintainers.map(m => m.name || m.email).join(', ') }) + +const compactNumberFormatter = useCompactNumberFormatter() diff --git a/app/pages/search.vue b/app/pages/search.vue index eb424d7ddc..b306359ca7 100644 --- a/app/pages/search.vue +++ b/app/pages/search.vue @@ -809,7 +809,7 @@ onBeforeUnmount(() => { $t( 'filters.count.showing_paginated', { - pageSize: Math.min(preferredPageSize, effectiveTotal), + pageSize: $n(Math.min(preferredPageSize, effectiveTotal)), count: $n(effectiveTotal), }, effectiveTotal, From 848aedf3257f443a6b22eab97737838ff00ef6c8 Mon Sep 17 00:00:00 2001 From: Denys Date: Thu, 19 Mar 2026 23:01:48 +0000 Subject: [PATCH 2/2] fix: do a proper null check --- app/components/Package/TableRow.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/components/Package/TableRow.vue b/app/components/Package/TableRow.vue index a79939658c..1a105b7e70 100644 --- a/app/components/Package/TableRow.vue +++ b/app/components/Package/TableRow.vue @@ -84,7 +84,11 @@ const compactNumberFormatter = useCompactNumberFormatter() v-if="isColumnVisible('downloads')" class="py-2 px-3 font-mono text-xs text-fg-muted text-end tabular-nums" > - {{ result.downloads?.weekly ? compactNumberFormatter.format(result.downloads.weekly) : '-' }} + {{ + result.downloads?.weekly !== undefined + ? compactNumberFormatter.format(result.downloads.weekly) + : '-' + }}