fix(config): be more aggressive about hiding protected values#7504
Merged
fix(config): be more aggressive about hiding protected values#7504
Conversation
wraithgar
commented
May 10, 2024
Comment on lines
+359
to
+362
| _auth = (protected) | ||
| //nerfdart:_auth = (protected) | ||
| //nerfdart:auth = (protected) | ||
| auth = (protected) |
Member
Author
There was a problem hiding this comment.
here is the actual new snapshot, whitespace fix notwithstanding.
Err on the side of not displaying things even if they're not valid config
316e312 to
16970fa
Compare
Collaborator
|
no statistically significant performance changes detected timing results
|
lukekarrys
approved these changes
May 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Err on the side of not displaying things even if they're not valid config