Skip to content

testing against LTS release and Current#210

Merged
ghinks merged 1 commit into
masterfrom
Eomm-patch-1
May 17, 2019
Merged

testing against LTS release and Current#210
ghinks merged 1 commit into
masterfrom
Eomm-patch-1

Conversation

@Eomm

@Eomm Eomm commented May 14, 2019

Copy link
Copy Markdown
Member

Closes #207

I would like to add a link to #146 or we can build a menu in the README.md

* LTS (long time support)
* Current

Of course, you are freely to maintain a package that run also with older versions of Node.js that reach the "end-of-life" stage.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like something here that more strongly encourages testing as far back as possible, to make updating node easier for consumers, and maximize back compat.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, consider supporting older versions of Node.js that reach the "end-of-life" stage also.
This lets your users to upgrade easily from an older version of your module to a new one.

could works this sentence?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghinks ghinks merged commit 14b5f74 into master May 17, 2019
@Eomm Eomm deleted the Eomm-patch-1 branch May 17, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update testing guidance to recommend testing against LTS release and Current.

4 participants