From 580b979ddd3df8c6769fc8e0fe731d19d07ed48a Mon Sep 17 00:00:00 2001 From: Aniket Singh Yadav Date: Fri, 20 Feb 2026 12:49:31 +0000 Subject: [PATCH 1/4] accept Nz as alternative nasion label --- mne/io/snirf/_snirf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mne/io/snirf/_snirf.py b/mne/io/snirf/_snirf.py index 020e55f4d91..1b3f940a58d 100644 --- a/mne/io/snirf/_snirf.py +++ b/mne/io/snirf/_snirf.py @@ -399,7 +399,7 @@ def natural_keys(text): dign = dign.lower() if dign in [b"lpa", b"al"]: lpa = diglocs[idx, :3] - elif dign in [b"nasion"]: + elif dign in [b"nasion", b"nz"]: nasion = diglocs[idx, :3] elif dign in [b"rpa", b"ar"]: rpa = diglocs[idx, :3] From 2f0a1ea912187cb3fcc241610e8ae592583f70d9 Mon Sep 17 00:00:00 2001 From: Aniket Singh Yadav Date: Fri, 20 Feb 2026 17:15:32 +0000 Subject: [PATCH 2/4] accept Nz as alternative nasion label --- mne/io/tests/test_raw.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/mne/io/tests/test_raw.py b/mne/io/tests/test_raw.py index c03963c9854..13cf958d2ff 100644 --- a/mne/io/tests/test_raw.py +++ b/mne/io/tests/test_raw.py @@ -520,13 +520,16 @@ def _test_raw_reader( # make sure that dig points in head coords implies that fiducials are # present if len(raw.info["dig"] or []) > 0: - card_pts = [ - d for d in raw.info["dig"] if d["kind"] == _dig_kind_dict["cardinal"] + card_pts_head = [ + d + for d in raw.info["dig"] + if d["kind"] == _dig_kind_dict["cardinal"] + and d["coord_frame"] == FIFF.FIFFV_COORD_HEAD ] eeg_dig_head = [d for d in eeg_dig if d["coord_frame"] == FIFF.FIFFV_COORD_HEAD] if len(eeg_dig_head): - assert len(card_pts) == 3, "Cardinal points missing" - if len(card_pts) == 3: # they should all be in head coords then + assert len(card_pts_head) == 3, "Cardinal points missing" + if len(card_pts_head) == 3: # they should all be in head coords then assert len(eeg_dig_head) == len(eeg_dig) return raw From a6428c3e1a8dd4e4eba7b60f34aca375e2ea5d67 Mon Sep 17 00:00:00 2001 From: Aniket Singh Yadav Date: Tue, 24 Feb 2026 04:55:32 +0000 Subject: [PATCH 3/4] Add chnagelog entry --- doc/changes/dev/13672.bugfix.rst | 1 + doc/changes/names.inc | 1 + 2 files changed, 2 insertions(+) create mode 100644 doc/changes/dev/13672.bugfix.rst diff --git a/doc/changes/dev/13672.bugfix.rst b/doc/changes/dev/13672.bugfix.rst new file mode 100644 index 00000000000..d75a53f6d14 --- /dev/null +++ b/doc/changes/dev/13672.bugfix.rst @@ -0,0 +1 @@ +Allow reading alternative nasion label ("Nz") in SNIRF files when parsing landmarkPos3D, by `Aniket Singh Yadav`_. \ No newline at end of file diff --git a/doc/changes/names.inc b/doc/changes/names.inc index 79db14d44e3..09c5818b6af 100644 --- a/doc/changes/names.inc +++ b/doc/changes/names.inc @@ -22,6 +22,7 @@ .. _Andrew Gilbert: https://github.com/adgilbert .. _Andrew Quinn: https://github.com/ajquinn .. _Aniket Pradhan: https://github.com/Aniket-Pradhan +.. _Aniket Singh Yadav: https://github.com/Aniketsy .. _Anna Padee: https://github.com/apadee/ .. _Annalisa Pascarella: https://github.com/annapasca .. _Anne-Sophie Dubarry: https://github.com/annesodub From b5eea4eb3c3ef4144bfb6331f61e5311a5a327fc Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Tue, 24 Feb 2026 09:55:27 -0600 Subject: [PATCH 4/4] Update doc/changes/dev/13672.bugfix.rst --- doc/changes/dev/13672.bugfix.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/changes/dev/13672.bugfix.rst b/doc/changes/dev/13672.bugfix.rst index d75a53f6d14..3cf463e11d7 100644 --- a/doc/changes/dev/13672.bugfix.rst +++ b/doc/changes/dev/13672.bugfix.rst @@ -1 +1 @@ -Allow reading alternative nasion label ("Nz") in SNIRF files when parsing landmarkPos3D, by `Aniket Singh Yadav`_. \ No newline at end of file +Allow reading alternative nasion label ("Nz") in SNIRF files when parsing landmarkPos3D, by :newcontrib:`Aniket Singh Yadav`. \ No newline at end of file