Helm chart improvements#1802
Open
babykart wants to merge 5 commits into
Open
Conversation
Signed-off-by: babykart <babykart@gmail.com>
Signed-off-by: babykart <babykart@gmail.com>
Signed-off-by: babykart <babykart@gmail.com>
Signed-off-by: babykart <babykart@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Garnet Helm chart to use Kubernetes-native ServiceAccount token automounting and to expose Service IP family configuration for cluster networking.
Changes:
- Replaces
serviceAccount.tokenwithserviceAccount.automount. - Removes the custom ServiceAccount token Secret template.
- Adds
service.ipFamiliesandservice.ipFamilyPolicyvalues and renders them on the main Service.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
charts/garnet/values.yaml |
Updates ServiceAccount values and adds Service IP family defaults. |
charts/garnet/templates/token.yaml |
Removes the generated ServiceAccount token Secret. |
charts/garnet/templates/serviceaccount.yaml |
Adds automountServiceAccountToken to created ServiceAccounts. |
charts/garnet/templates/service.yaml |
Adds IP family fields to the main Service spec. |
Comments suppressed due to low confidence (3)
charts/garnet/values.yaml:120
- The generated chart README is not updated for these new service values, so users will not see
service.ipFamiliesorservice.ipFamilyPolicyin the published values table unless the README is regenerated with helm-docs.
# -- Service port
port: 6379
# -- Service ipFamilies
ipFamilies:
- IPv4
charts/garnet/templates/token.yaml:1
- Deleting this template removes the
serviceAccount.tokenbehavior entirely.automountServiceAccountTokencontrols Pod token volume mounting but does not create the named ServiceAccount token Secret that existing users withserviceAccount.token: truemay consume, so this is a breaking chart API change unless a compatibility path or migration note is provided.
charts/garnet/templates/service.yaml:17 - These fields are emitted even when the corresponding values are empty or unset, which renders null values such as
ipFamilies:oripFamilyPolicy:rather than omitting the fields. Kubernetes expects valid values here, so users cannot fall back to cluster defaults without producing an invalid Service manifest.
ipFamilies:
{{- with .Values.service.ipFamilies }}
{{- toYaml . | nindent 4 }}
{{- end }}
ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }}
Comment on lines
+118
to
+122
| # -- Service ipFamilies | ||
| ipFamilies: | ||
| - IPv4 | ||
| # -- Service ipFamilyPolicy SingleStack|PreferDualStack|RequireDualStack | ||
| ipFamilyPolicy: SingleStack |
Contributor
Author
There was a problem hiding this comment.
The new default is the kubernetes default behavior.
Comment on lines
+13
to
+17
| ipFamilies: | ||
| {{- with .Values.service.ipFamilies }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }} |
Comment on lines
+39
to
+40
| # -- Automatically mount the service account token | ||
| automount: false |
Contributor
Author
There was a problem hiding this comment.
The README.md will be updated & commited by the helm-chart github workflow.
Comment on lines
+39
to
+40
| # -- Automatically mount the service account token | ||
| automount: false |
Comment on lines
+12
to
13
| automountServiceAccountToken: {{ .Values.serviceAccount.automount | default false }} | ||
| {{- end }} |
Signed-off-by: babykart <babykart@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
values.schema.jsonfile.