From 0f0f30ebef083aed16c242af4142455fc1f99855 Mon Sep 17 00:00:00 2001 From: Mark Wieder Date: Thu, 8 Aug 2019 14:25:36 -0700 Subject: [PATCH 1/3] This patches the property inspector to do a revUnsubscribeAll on closing. The problem reported in bug report 22297 being that the property inspector subscribes to the idePropertyChanged message but doesn't unsubscribe from that message if the selected object hasn't changed, as for example if you try to edit the script of an object after having looked at its properties. --- .../palettes/inspector/revinspectortemplate.livecodescript | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Toolset/palettes/inspector/revinspectortemplate.livecodescript b/Toolset/palettes/inspector/revinspectortemplate.livecodescript index 84d8bfc882..f82b394e17 100644 --- a/Toolset/palettes/inspector/revinspectortemplate.livecodescript +++ b/Toolset/palettes/inspector/revinspectortemplate.livecodescript @@ -29,8 +29,8 @@ end openStack on closeStack ## Unsubscribe from all messages - revIDEUnsubscribe "idePreferenceChanged:idePropertyInspector_labels" - + revIDEUnsubscribeAll + set the cSelectedObjects of me to empty # Unlock From b367b845c37f577f09514485036e93a7fd520d4e Mon Sep 17 00:00:00 2001 From: Mark Wieder Date: Mon, 12 Aug 2019 08:58:26 -0700 Subject: [PATCH 2/3] Fixed per the note from panos --- Toolset/palettes/inspector/revinspectortemplate.livecodescript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolset/palettes/inspector/revinspectortemplate.livecodescript b/Toolset/palettes/inspector/revinspectortemplate.livecodescript index f82b394e17..b2275ea65d 100644 --- a/Toolset/palettes/inspector/revinspectortemplate.livecodescript +++ b/Toolset/palettes/inspector/revinspectortemplate.livecodescript @@ -29,7 +29,7 @@ end openStack on closeStack ## Unsubscribe from all messages - revIDEUnsubscribeAll + revIDEUnsubscribeAll the long id of me set the cSelectedObjects of me to empty From 78157b6a362431618af36298bdf78585701fe2c8 Mon Sep 17 00:00:00 2001 From: Mark Wieder Date: Mon, 12 Aug 2019 09:01:46 -0700 Subject: [PATCH 3/3] Fixed properly this time (both unsubscribes in place) --- Toolset/palettes/inspector/revinspectortemplate.livecodescript | 1 + 1 file changed, 1 insertion(+) diff --git a/Toolset/palettes/inspector/revinspectortemplate.livecodescript b/Toolset/palettes/inspector/revinspectortemplate.livecodescript index b2275ea65d..7a97093443 100644 --- a/Toolset/palettes/inspector/revinspectortemplate.livecodescript +++ b/Toolset/palettes/inspector/revinspectortemplate.livecodescript @@ -29,6 +29,7 @@ end openStack on closeStack ## Unsubscribe from all messages + revIDEUnsubscribeAll revIDEUnsubscribeAll the long id of me set the cSelectedObjects of me to empty