Minor enhancements to rate limiting information#186
Merged
Conversation
If rate limiting information hasn't been retrieved already, it will be checked rather than just assuming 5000 requests remaining of 5000. Add an additional attribute `rate_limiting_resettime` to reflect github's new X-RateLimit-Reset header. This integer value is a unix timestamp. RateLimiting unit test updated accordingly.
Member
|
Thank you for you contribution! I'm back from holidays, I will integrate your work in the next release of PyGithub. |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If rate limiting information hasn't been retrieved already, it will be checked (against the
/rate_limitendpoint) rather than just assuming 5000 requests remaining of 5000.Add an additional attribute
rate_limiting_resettimeto reflect github's newX-RateLimit-Resetheader. This integer value is a unix timestamp. (In order to avoid breaking anyone's code, I added a new attribute rather than adding a third value to therate_limitingtuple.)RateLimiting unit test updated accordingly. I'm pretty sure I did the right thing in re-recording the replay data, but please double-check this.