Allow reverse pagination#184
Merged
Merged
Conversation
This uses the 'last' and 'prev' links in the HTTP headers. The usage is repo.get_issues().reversed
Contributor
Author
|
sorry for the broken build. fixing now. |
Fixes a bug introduced in the previous commits. Now testing a case where no lastUrl is returned. Also fixing a regression where nextUrl wasn't erased properly.
Changed reversed(content) to content[::-1] in order to return a real list and not a generator. The code in PaginatedListBase.__grow does an iteration over newElements when using `+=` and then returns them. When using a generator, newElements would be empty when they are returned.
|
nice, that could be useful! |
Contributor
Author
|
I didn't add any documentation. |
Member
|
This sounds interesting, thank you! I'm back from holidays, I will analyze this PR in details soon. |
ghost
assigned
jacquev6
added a commit
that referenced
this pull request
Aug 21, 2013
This will avoid surprises if both the list and its reversed version are iterated.
jacquev6
added a commit
that referenced
this pull request
Aug 21, 2013
jacquev6
added a commit
that referenced
this pull request
Aug 21, 2013
Contributor
Author
|
cool 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a feature to
PaginatedListto allow iteration in reversed order.As a follow up do the discussion in #180