Populates Issue's repository from URL when not in response.#181
Merged
Conversation
Member
|
Thank you for your contribution! To be honest, I'm not sure about that... Until now, PyGithub never interferes with what is returned by Github API v3. I'll think about it in the next few days. |
Contributor
Author
|
I certainly see your point. However, it is frustrating that Anyways, let me know what you decide, and thanks for the project. |
Member
|
You're right, I'll merge that in next release. Later, I will try to find a more generic way to help objects know their parents (here, we do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues created from
Repository.get_issue()have theirrepositoryfield set to None. This pull request manually sets the Issue's repository using the Issue's URL, when the repository has not already been set.I've also modified the test in
tests.Issue.Issue.testAttributesto verify that the repository is correctly set. The modified test does fail if I remove my changes to the library.