Persist address and slot warmth in CREATE[2] calls.#1468
Merged
Conversation
The warm address/slot data was not returned to the calling messageFrame for CREATE[2] calls as it was for CALL series calls. Also, improve performance by using more efficient copy constructors and reusing objects were relevant. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
holiman
approved these changes
Oct 18, 2020
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
This appears to fix the testcases found via fuzzing. Nothing new found yet
|
Update: 28K tests executed, no issues found |
shemnon
added a commit
to shemnon/besu
that referenced
this pull request
Oct 19, 2020
The warm address/slot data was not returned to the calling messageFrame for CREATE[2] calls as it was for CALL series calls. Also, improve performance by using more efficient copy constructors and reusing objects were relevant. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> (cherry picked from commit 43abf83) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
shemnon
added a commit
that referenced
this pull request
Oct 20, 2020
The warm address/slot data was not returned to the calling messageFrame for CREATE[2] calls as it was for CALL series calls. Also, improve performance by using more efficient copy constructors and reusing objects were relevant. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> (cherry picked from commit 43abf83) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warm address/slot data was not returned to the calling messageFrame
for CREATE[2] calls as it was for CALL series calls.
Also, improve performance by using more efficient copy constructors and
reusing objects were relevant.
Addresses holiman/goevmlab#24
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
Changelog