Fix timestamp offset bug in BLFWriter#1921
Merged
pierreluctg merged 3 commits intomainfrom Feb 25, 2025
Merged
Conversation
zariiii9003
approved these changes
Feb 20, 2025
Collaborator
zariiii9003
left a comment
There was a problem hiding this comment.
That makes sense. Maybe add a code comment, so this does not get "optimized" away in the future.
In the BLF files, the frame timestamp are stored as a delta from the "start time". The "start time" stored in the file is the first frame timestamp rounded to 3 decimals. When we calculate the timestamp delta for each frame, we were previously calculating it using the non-rounded "start time". This new code, use the "start time" as the first frame timestamp truncated to 3 decimals.
Making sure all tests messages contains a timestamp to avoid situation where the first written message have timestamps equal to zero.
Adding comment
d54c2ca to
001e5eb
Compare
Collaborator
Author
I have also updated/fix the unit tests test data to avoid hitting this issue in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the BLF files, the frame timestamp are stored as a delta from the "start time". The "start time" stored in the file is the first frame timestamp rounded to 3 decimals. When we calculate the timestamp delta for each frame, we were previously calculating it using the non-rounded "start time".
This new code, use the "start time" as the first frame timestamp truncated to 3 decimals.
This code can be used to test if the written timestamps are the same that we read back from the BLF file.