use shared strings for streamed writes#233
Merged
guyonroche merged 1 commit intoexceljs:masterfrom Dec 2, 2016
pookong:use_shared_strings_for_streamed_write
Merged
use shared strings for streamed writes#233guyonroche merged 1 commit intoexceljs:masterfrom pookong:use_shared_strings_for_streamed_write
guyonroche merged 1 commit intoexceljs:masterfrom
pookong:use_shared_strings_for_streamed_write
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream writer did not use shared strings even if the useSharedStrings option was enabled due to variable name mismatch between
WorkbookWriter-lib/stream/xlsx/workbook-writer.js:59-this.streamedValuesWorksheetWriter-lib/stream/xlsx/worksheet-writer.js:454-self._workbook.sharedStrings