fix: add pause for the staleness test#762
Merged
asthamohta merged 2 commits intogoogleapis:mainfrom Jul 5, 2022
Merged
Conversation
product-auto-label
bot
added
size: xs
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Author
|
@asthamohta, this one seems to be ready for merge |
asthamohta
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_stalenesstest is checking if reading with steleness is possible. It takes the timestamp, then inserts a row, then is trying to read the database by the timestamp taken before the insert. However, from time to time the inserted row is read. Not 100% sure about precision Cloud Spanner is using for staleness (in the docs it's said than 10 seconds staleness is recommended as the minimal bound), but it feels like from time to time taking the timestamp and the row insertion are done too fast, so Spanner considers that the row is already inserted at the moment of the timestamp. If so, adding a small pause between taking the timestamp and row insertion should fix the problem.Closes #752