Merged
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
tseaver
suggested changes
Nov 30, 2021
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
Ideally we would be testing google/ and tests/, and without the --ignore-missing-imports flag (the --no-incremental flat shouldn't be needed, either -- one can just remove .mypy_cache to blow the cache away). That would likely require adding some more types- packages (e.g. types-protobuf, types-mock).
We would then be adding py.typed to the remaining subdirs of google/cloud/, in particular, to google/cloud/spanner_dbapi/.
| import pkg_resources | ||
|
|
||
| __version__ = pkg_resources.get_distribution("google-cloud-spanner").version | ||
| __version__: str = pkg_resources.get_distribution("google-cloud-spanner").version |
Contributor
There was a problem hiding this comment.
This annotation shouldn't be needed, since you have installed types-setuptools in the nox session.
asthamohta
approved these changes
Jul 7, 2022
asthamohta
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #625
py.typedfile is already added into the repository and is included in the package. Implementing a newnoxsession to check types withmypy.