This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: remove discontinued sqlglot type attribute from the vendored ibis code#1379
Merged
chore: remove discontinued sqlglot type attribute from the vendored ibis code#1379
Conversation
This type has been removed in sqlglot head tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c.
product-auto-label
bot
added
the
api: bigquery
shobsi
changed the title
UNIQUEIDENTIFIER from the vendored ibis datatypes
shobsi
changed the title
sycai
approved these changes
Feb 10, 2025
shuoweil
pushed a commit
that referenced
this pull request
Feb 10, 2025
This type has been removed in sqlglot head tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type attribute
UNIQUEIDENTIFIERhas been removed in sqlglot headtobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c which is causing
unit_prereleasetests fail withAttributeError: type object 'Type' has no attribute 'UNIQUEIDENTIFIER':Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 395193422 🦕