Skip to content

fix: correct repository URLs in core package.json files#8722

Merged
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
pearigee-fix-repository-urls
Jun 24, 2026
Merged

fix: correct repository URLs in core package.json files#8722
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
pearigee-fix-repository-urls

Conversation

@pearigee

Copy link
Copy Markdown
Contributor

Many repository URLs in the core directory are outdated. This can break release please when it tries to grab the latest tag for each package.

This PR updates the repository URLs, directories, and any links to older repos.

@pearigee pearigee requested review from a team as code owners June 24, 2026 16:39
@pearigee pearigee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository, homepage, and bug tracker URLs across multiple package.json files to reflect the migration from google-cloud-node-core to google-cloud-node and the updated directory structure. The reviewer suggests using the full object format with a directory field instead of a shorthand string for the repository field in several sample package.json files to maintain consistency and ensure accurate metadata.

Comment thread core/packages/gax/samples/package.json
Comment thread core/packages/gcp-metadata/samples/package.json
Comment thread core/packages/nodejs-googleapis-common/samples/package.json
Comment thread core/packages/nodejs-proto-files/samples/package.json
Comment thread core/packages/proto3-json-serializer-nodejs/samples/package.json
@pearigee pearigee added the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2026
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 368f18e into main Jun 24, 2026
47 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2026
@gcf-merge-on-green gcf-merge-on-green Bot deleted the pearigee-fix-repository-urls branch June 24, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants