Skip to content

fix(pubsub): increase streaming pull timeout#8345

Merged
feywind merged 2 commits into
mainfrom
fix-pubsub-streaming-timeout
May 21, 2026
Merged

fix(pubsub): increase streaming pull timeout#8345
feywind merged 2 commits into
mainfrom
fix-pubsub-streaming-timeout

Conversation

@hongalex

Copy link
Copy Markdown
Member

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label May 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the timeout_millis for the StreamingPull RPC from 15 to 30 minutes in the subscriber configuration. Feedback indicates that this change may be ineffective without a corresponding update to the total_timeout_millis in the retry parameters, as the RPC terminates based on whichever limit is reached first.

Comment thread handwritten/pubsub/src/v1/subscriber_client_config.json
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2026
@feywind feywind merged commit 08959de into main May 21, 2026
30 of 31 checks passed
@feywind feywind deleted the fix-pubsub-streaming-timeout branch May 21, 2026 21:41
shivanee-p pushed a commit that referenced this pull request May 22, 2026
* fix(pubsub): increase streaming pull timeout

Pub/Sub streaming pull timeout should be increased to match the values in https://github.com/googleapis/googleapis/blob/master/google/pubsub/v1/pubsub_grpc_service_config.json

* Increase RPC timeout values in subscriber config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants