feat(ir): add typed builder for SonarQubePublish@8 - #1268
Merged
Conversation
Add SonarQubePublish builder struct to complete the SonarQube pipeline trio (SonarQubePrepare → SonarQubeAnalyze → SonarQubePublish). The task has a single input (pollingTimeoutSec, ADO default 300) so new() requires no arguments; polling_timeout_sec() is provided as an optional setter for callers who need a non-default timeout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…blish-b027108c435468a8
Integrates the SonarQubePublish@8 typed builder with the front-matter task-step advisory validation added in #1096: derives Deserialize keyed on the ADO pollingTimeoutSec input (deny_unknown_fields, flex str/int) and registers it in parse.rs VALIDATORS. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed builder struct for
SonarQubePublish@8to the ado-aw IR, completing the SonarQube pipeline trio alongside the previously contributedSonarQubePrepare@8andSonarQubeAnalyze@8builders.Motivation
Previously, any code that needed to emit a
SonarQubePublish@8task step had to hand-craftTaskStep::new(...)with raw string input keys. This PR introduces a typed builder struct (new()+ optionalpolling_timeout_sec()setter +into_step()) so the only available input is type-checked and the builder enforces the correct ADO defaults.Changes
src/compile/ir/tasks/sonar_qube_publish.rs: newSonarQubePublishbuilder struct and its#[cfg(test)] mod tests(5 tests)src/compile/ir/tasks/mod.rs:pub mod sonar_qube_publish;declaration (alphabetical order, betweenpublish_test_resultsandtwine_authenticate)ADO Task Reference
SonarQubePublish@8https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/sonar-qube-publish-v8-taskpollingTimeoutSecis required but has ADO default300pollingTimeoutSec(u32, defaults to300on the ADO side)Validation
cargo build --all-targetscargo test(5 new unit tests, all passing)cargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.