feat(ir): add typed builder for AzureContainerApps@1 - #1200
Merged
jamesadevine merged 2 commits intoJun 26, 2026
Conversation
Introduces a typed builder struct for the AzureContainerApps@1 ADO task, covering both build-from-source and deploy-existing-image usage patterns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
jamesadevine
marked this pull request as ready for review
June 25, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed builder struct for
AzureContainerApps@1to the ado-aw IR.Motivation
Previously, any code that needed to emit an Azure Container Apps deploy step had to hand-craft
TaskStep::new(...)with raw string input keys. This PR introduces a typed builder struct (new(<required>)+ typed optional setters +into_step()) so required inputs are positional, optional inputs and their constrained values are type-checked, and call sites stop using stringly-typed keys.Changes
src/compile/ir/tasks/azure_container_apps.rs: newAzureContainerAppsbuilder struct,ContainerAppIngressenum, and a#[cfg(test)] mod testswith 6 tests covering required-only, deploy-existing-image, build-from-source, ingress enum variants, optional fields, and yaml-config-path patterns.src/compile/ir/tasks/mod.rs:pub mod azure_container_apps;declaration (alphabetical order, betweenazure_cliandazure_key_vault).ADO Task Reference
AzureContainerApps@1azureSubscription(Azure RM service connection)workingDirectory,appSourcePath,acrName,acrUsername,acrPassword,dockerfilePath,imageToBuild,imageToDeploy,containerAppName,resourceGroup,containerAppEnvironment,runtimeStack,targetPort,location,environmentVariables,ingress(typedContainerAppIngressenum),yamlConfigPath,disableTelemetryUsage examples
Deploy an existing image:
Build from source and deploy:
Validation
cargo build --all-targetscargo test azure_container_apps— 6 tests, all passcargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.