feat(ir): add typed helper for ExtractFiles@1#1042
Merged
Conversation
Adds `extract_files_step()` factory function to `src/compile/ir/tasks.rs`. Required inputs are positional parameters (`archiveFilePatterns`, `destinationFolder`); optional inputs (`cleanDestinationFolder`, `overwriteExistingFiles`, `pathToSevenZipTool`) are applied via `.with_input(…)` on the returned `TaskStep`. Four unit tests cover: required-input defaults, optional clean/overwrite flags, custom 7z path, and multiline archive patterns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
Jun 15, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed factory function
extract_files_step()forExtractFiles@1tosrc/compile/ir/tasks.rs.Motivation
Previously, any compiler code that needed to emit an
ExtractFiles@1pipeline step had to hand-craftTaskStep::new("ExtractFiles@1", ...)with raw string input keys. This PR introduces a well-typed helper that makes required inputs explicit at the call site and documents the optional inputs table inline.Changes
src/compile/ir/tasks.rs:extract_files_step()factory function with full doc comment (required/optional inputs table, ADO task reference link)extract_files_step_sets_task_and_required_inputs— verifies task ID, display name, and both required input keysextract_files_step_accepts_optional_clean_and_overwrite— verifiescleanDestinationFolderandoverwriteExistingFilesvia.with_input(...)extract_files_step_accepts_custom_seven_zip_path— verifiespathToSevenZipTooloptional inputextract_files_step_multiline_patterns— verifies multi-pattern strings are passed through verbatimADO Task Reference
ExtractFiles@1archiveFilePatterns(default**/*.zip),destinationFoldercleanDestinationFolder(bool, defaulttrue),overwriteExistingFiles(bool, defaultfalse),pathToSevenZipTool(string)Validation
cargo build --all-targetscargo testcargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.