fix(validate): block workspace alias shell injection in generated bash steps#1018
Merged
Merged
Conversation
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix shell injection vulnerability in workspace alias
fix(validate): block workspace alias shell injection in generated bash steps
Jun 15, 2026
jamesadevine
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace alias values were validated too loosely, allowing shell metacharacters to pass into generated double-quoted bash arguments (
--container-workdir/ SafeOutputs bounding dir). This change closes that injection path by hardening alias validation and adding workspace-level expression rejection.Validation hardening
is_safe_path_segmentto a strict allowlist:[A-Za-z0-9._-]..,/,\, leading.,\n,\r)Defense-in-depth on front matter
validate_front_matter_identityto runreject_pipeline_injectiononworkspaceRegression coverage
workspaceTest plan
Covered by existing and newly added unit tests in
src/validate.rsandsrc/compile/common.rs.