Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

consolidated config settings, dedupe constants#86

Merged
primetheus merged 13 commits into
mainfrom
primetheus/consolidate-config
Aug 14, 2020
Merged

consolidated config settings, dedupe constants#86
primetheus merged 13 commits into
mainfrom
primetheus/consolidate-config

Conversation

@primetheus

@primetheus primetheus commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Closes #82
Closes #85
Closes #88

Proposed Changes

  • Migrate rallyObjects to rally.objects
  • Migrate rallyProjects to rally.projects
  • Migrate artifactStatuses to rally.states
  • Deduplicate project and statuses in the check
  • Adds JSDocs to the code

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

@zkoppert

Copy link
Copy Markdown
Member

Looks like there should also be changes to the names in rally.yml?

Switched to a new branch 'primetheus/consolidate-config'

Zacherys-MacBook-Pro:rally zkoppert$ git grep rallyObjects ./*
rally.yml:rallyObjects: ['defect', 'userstory']

Zacherys-MacBook-Pro:rally zkoppert$ git grep rallyProjects ./*
rally.yml:rallyProjects: ['Sample Project', 'devops-engineering']

Zacherys-MacBook-Pro:rally zkoppert$ git grep artifactStatuses ./*
lib/RallyValidate.js:    artifactStatuses: ['Open', 'To Do', 'In Progress']
rally.yml:artifactStatuses: ['Defined', 'In-Progress']

@primetheus primetheus requested a review from steffen August 13, 2020 21:43
steffen
steffen previously approved these changes Aug 13, 2020

@steffen steffen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@zkoppert

Copy link
Copy Markdown
Member

Looks like the super linter wants standard to run and fix indenting. I'm going to run that locally now and push here.

Signed-off-by: Zack Koppert <zkoppert@github.com>

@zkoppert zkoppert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zkoppert zkoppert mentioned this pull request Aug 13, 2020
1 task
@primetheus primetheus merged commit e70e828 into main Aug 14, 2020
@primetheus primetheus deleted the primetheus/consolidate-config branch August 14, 2020 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JSDoc Consolidate rally config items Duplicate Projects and valid artifact states

3 participants