Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

commentOnPull functionality#253

Merged
zkoppert merged 6 commits into
mainfrom
zk-integration
Apr 27, 2021
Merged

commentOnPull functionality#253
zkoppert merged 6 commits into
mainfrom
zk-integration

Conversation

@zkoppert

@zkoppert zkoppert commented Apr 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed Changes

  • commentOnPull functionality
    • Had to move this to an integration branch to get the linter to kick off

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

Reviewer Checklist

  • If a functional change has occurred, testing the integration has been performed
  • This PR has been categorized with a label (1 of automation, bug, documentation, enhancement, infrastructure, or performance) for the changelog

@zkoppert zkoppert added the enhancement New feature or request label Apr 21, 2021
zkoppert added 2 commits April 20, 2021 23:21
@zkoppert
standard fixes formatting
bf80d84 
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert
bypass linter for dumb thing
5d8154e 
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert changed the title Integrate comment on pull request into main commentOnPull functionality Apr 21, 2021
@zkoppert

zkoppert commented Apr 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@vorobievalex Do you have a moment to take a look at the build errors in the checks tab of this PR?

@vorobievalex

vorobievalex commented Apr 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@zkoppert , Node CI has failed on 12.x with no logs.
Build-test has failed with GitHub Actions has encountered an internal error when running your job.
Could you re-run it? It could be a CI infrastructure problem.

@zkoppert

zkoppert commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

Looks like it was an infrastructure issue with the CI. Re-running fixed it!

@zkoppert zkoppert merged commit 92bb92d into main Apr 27, 2021
@zkoppert zkoppert deleted the zk-integration branch April 27, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@migarjo migarjo Awaiting requested review from migarjo

@steffen steffen Awaiting requested review from steffen

1 more reviewer

@primetheus primetheus primetheus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zkoppert @vorobievalex @primetheus