From 4e09f69bd5b8dcbe779eb630b83cd3746b117301 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 27 Dec 2025 04:16:24 +0000 Subject: [PATCH] Fix unhandled error in mcp_inspect.go cleanup (Alert #407) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added error handling for os.RemoveAll(tmpDir) at line 504 to properly check and log cleanup failures. This satisfies gosec G104 rule. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- pkg/cli/mcp_inspect.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/cli/mcp_inspect.go b/pkg/cli/mcp_inspect.go index fc072e7ee0d..14f2fe81167 100644 --- a/pkg/cli/mcp_inspect.go +++ b/pkg/cli/mcp_inspect.go @@ -501,7 +501,10 @@ func startSafeInputsServer(safeInputsConfig *workflow.SafeInputsConfig, verbose // Write safe-inputs files to temporary directory if err := writeSafeInputsFiles(tmpDir, safeInputsConfig, verbose); err != nil { - os.RemoveAll(tmpDir) + // Clean up temporary directory on error + if err := os.RemoveAll(tmpDir); err != nil && verbose { + mcpInspectLog.Printf("Warning: failed to clean up temporary directory %s: %v", tmpDir, err) + } return nil, nil, "", fmt.Errorf("failed to write safe-inputs files: %w", err) }