Migrate Deploy command to Skill#91
Migrate Deploy command to Skill#91alex-doudou wants to merge 3 commits intogemini-cli-extensions:mainfrom
Conversation
alex-doudou
commented
Mar 11, 2026
alex-doudou
commented
- Migrate Deploy command to Skill
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the Deploy command to a Skill by adding a new SKILL.md file. The new skill definition is well-structured, but I've found several typos and grammatical errors in the markdown file. Correcting these will improve the clarity and professionalism of the documentation. I've added specific comments with suggestions for each issue.
skills/gcp-cicd-deploy/SKILL.md
Outdated
| ## Core Operational Logic: Intent Analysis | ||
|
|
||
| ### **Explain your plan:** | ||
| * Before taking any actions, clearly explain to the user what your going to do. |
There was a problem hiding this comment.
There's a grammatical error here. 'your' should be 'you're'.
| * Before taking any actions, clearly explain to the user what your going to do. | |
| * Before taking any actions, clearly explain to the user what you're going to do. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
|
|
||
| ### **Explain your plan:** | ||
| * Before taking any actions, clearly explain to the user what your going to do. | ||
| * Frist explain your plan and then perform anaylises of the project. |
There was a problem hiding this comment.
There are a couple of typos on this line: 'Frist' should be 'First', and 'anaylises' should be 'analyses'.
| * Frist explain your plan and then perform anaylises of the project. | |
| * Frist explain your plan and then perform analyses of the project. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
| * Frist explain your plan and then perform anaylises of the project. | ||
| * Once you have identified project's programming language and frameworks used, inform user of your findings, before performing further analysis. | ||
|
|
||
| ### **Application Type Analysis (Mandatory First Step):** Before taking any action, first analyse project to determine if it is a Static Site or a Dynamic Service. |
There was a problem hiding this comment.
For consistency with the rest of the document (e.g., line 20), 'analyse' should be spelled 'analyze'.
| ### **Application Type Analysis (Mandatory First Step):** Before taking any action, first analyse project to determine if it is a Static Site or a Dynamic Service. | |
| ### **Application Type Analysis (Mandatory First Step):** Before taking any action, first analyze project to determine if it is a Static Site or a Dynamic Service. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
| * If the type is a static application, follow **Workflow A: Google Cloud Storage**. | ||
| * If the type is a container based application, ask the user if they would like to deploy to Cloud Run using buildpacks or build an image. | ||
| * If the user would like to deploy to Cloud Run using buildpacks, follow **Workflow B: Google Cloud Run With Buildpacks**. | ||
| * If the user would liket to deploy to Cloud Run by building an image, follow **Workflow C: Google Cloud Run From Image**. Build and run the image on docker locally first before uploading the image to AR and running on cloud run. |
There was a problem hiding this comment.
There's a typo here: 'liket' should be 'like to'.
| * If the user would liket to deploy to Cloud Run by building an image, follow **Workflow C: Google Cloud Run From Image**. Build and run the image on docker locally first before uploading the image to AR and running on cloud run. | |
| * If the user would like to deploy to Cloud Run by building an image, follow **Workflow C: Google Cloud Run From Image**. Build and run the image on docker locally first before uploading the image to AR and running on cloud run. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
| Your job is to deploy the user's applications to Cloud Run using buildpacks. | ||
|
|
||
| 1. **Check if application is supported with Google Cloud buildpacks**: Check if the users application is in one of the following languages: Go, Node.js, Python, Java, .NET, Ruby, PHP. | ||
| * **If application is in one of these lenguages Node.js, Go, Java, .NET, Ruby PHP, Python it is supported by build packs. Dockerfile is not needed. Skip step 2. |
There was a problem hiding this comment.
There's a typo ('lenguages' should be 'languages') and a missing comma between 'Ruby' and 'PHP'.
| * **If application is in one of these lenguages Node.js, Go, Java, .NET, Ruby PHP, Python it is supported by build packs. Dockerfile is not needed. Skip step 2. | |
| * **If application is in one of these languages Node.js, Go, Java, .NET, Ruby, PHP, Python it is supported by build packs. Dockerfile is not needed. Skip step 2. |
|
|
||
| 1. **Check if application is supported with Google Cloud buildpacks**: Check if the users application is in one of the following languages: Go, Node.js, Python, Java, .NET, Ruby, PHP. | ||
| * **If application is in one of these lenguages Node.js, Go, Java, .NET, Ruby PHP, Python it is supported by build packs. Dockerfile is not needed. Skip step 2. | ||
| 2. **Create DockerFile if not supported by buildpacks**: If the users application is not supported by buildpacks, as found in step 1, look up how to build a Dockerfile. Then create a multistage Dockerfile to containerize the application. Analyze port, environmental variables etc and setup the Dockerfile in a way that it works. After that, ensure the Dockerfile can be built locally using the Docker cli. |
There was a problem hiding this comment.
For consistency with other mentions in the file (e.g., line 62), 'DockerFile' should be 'Dockerfile'.
| 2. **Create DockerFile if not supported by buildpacks**: If the users application is not supported by buildpacks, as found in step 1, look up how to build a Dockerfile. Then create a multistage Dockerfile to containerize the application. Analyze port, environmental variables etc and setup the Dockerfile in a way that it works. After that, ensure the Dockerfile can be built locally using the Docker cli. | |
| 2. **Create Dockerfile if not supported by buildpacks**: If the users application is not supported by buildpacks, as found in step 1, look up how to build a Dockerfile. Then create a multistage Dockerfile to containerize the application. Analyze port, environmental variables etc and setup the Dockerfile in a way that it works. After that, ensure the Dockerfile can be built locally using the Docker cli. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
| Your job is to deploy the user's applications to Cloud Run from an image. | ||
|
|
||
| 1. **Create Dockerfile**: If a Dockerfile does not already exist, look up how to build a Dockerfile and create a multistage Dockerfile to containerize the application. Analyze port, environmental variables etc and setup the Dockerfile in a way that it works. Ensure the Dockerfile can be built locally using the Docker cli. | ||
| 2. **Gather Parameters**: Analyze the request to find all necessary parameters to create an Artifact Registry repository and build and push the Docker image. If any mandatory parameters are missing, you MUST ask the user for them before proceesing. Do not guess or make assumptions. |
There was a problem hiding this comment.
There's a typo here: 'proceesing' should be 'proceeding'.
| 2. **Gather Parameters**: Analyze the request to find all necessary parameters to create an Artifact Registry repository and build and push the Docker image. If any mandatory parameters are missing, you MUST ask the user for them before proceesing. Do not guess or make assumptions. | |
| 2. **Gather Parameters**: Analyze the request to find all necessary parameters to create an Artifact Registry repository and build and push the Docker image. If any mandatory parameters are missing, you MUST ask the user for them before proceeding. Do not guess or make assumptions. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
|
|
||
| These rules apply to all workflows. | ||
|
|
||
| Always scan for secrets before uploading anything to docker or GCS using the `osv.scan_secrets` tool. Always ignore directories where scanning is not useful e.g. dependencies which the user has no control over e.g. .venv or go_modules etc. Warn the user of any secrets available and ask if the user wants to ignore these files using dockerignore and gitignore. If they would like to ignore the files, create the corresponding dockerignore and gitignore files. Goal of scanning is to detect if the user inadvertantly uploaded any secrets in *their* application code. |
There was a problem hiding this comment.
There's a typo here: 'inadvertantly' should be 'inadvertently'.
| Always scan for secrets before uploading anything to docker or GCS using the `osv.scan_secrets` tool. Always ignore directories where scanning is not useful e.g. dependencies which the user has no control over e.g. .venv or go_modules etc. Warn the user of any secrets available and ask if the user wants to ignore these files using dockerignore and gitignore. If they would like to ignore the files, create the corresponding dockerignore and gitignore files. Goal of scanning is to detect if the user inadvertantly uploaded any secrets in *their* application code. | |
| Always scan for secrets before uploading anything to docker or GCS using the `osv.scan_secrets` tool. Always ignore directories where scanning is not useful e.g. dependencies which the user has no control over e.g. .venv or go_modules etc. Warn the user of any secrets available and ask if the user wants to ignore these files using dockerignore and gitignore. If they would like to ignore the files, create the corresponding dockerignore and gitignore files. Goal of scanning is to detect if the user inadvertently uploaded any secrets in *their* application code. |
skills/gcp-cicd-deploy/SKILL.md
Outdated
| ### **Defaults** | ||
| * **Google Cloud**: If gcloud is installed use `gcloud config list` to get the default *project* and *region*. | ||
| * **Deployment Target**: You can propose default target name based on the following, BUT you **MUST** ask the user for confirmation before using it: | ||
| * If git is installed use `git remote get-url origin` to get the git url. From URL used repositoru name as default target name. |
There was a problem hiding this comment.
There's a typo here: 'repositoru' should be 'repository'.
| * If git is installed use `git remote get-url origin` to get the git url. From URL used repositoru name as default target name. | |
| * If git is installed use `git remote get-url origin` to get the git url. From URL used repository name as default target name. |
1 participant
