stalls in loop

[shimaore]

The loop at lib/line_wrapper.coffee line 77 might become an endless loop. In the example I have, this happens because @lineWidth was set to a negative value (columnGap is 18 and columns is 1, so I supposed this happened because options.width was negative.

[shimaore]

FWIW I do not set width in my code, I suppose it is set before it hits LineWrapper.

[shimaore]

This happens because I use doc.text(str,x,y) with x > page.width.

EDIT: This also happens if x < page.width when (I suspect) the text is still too large to fit between the position at x and the right margin.

[dekuenstle]

There is another case for the LineWrapper to stall when shorting the text in L149:

If the @lineWidth is smaller than the required space for @ellipses, the buffer will converge to an empty string but never exit the loop.

I would expect it to draw nothing and drop a warning in the logs.

@devongovett should I open a separate issue for this one?

[alafr]

This file has changed: https://github.com/devongovett/pdfkit/blob/master/lib/line_wrapper.coffee#L165 with pull request #779.
Can you confirm if the bug is still there?

[dekuenstle]

@alafr I'm sorry, I missed the merge.

Seems to be fixed. Thank you.

[shimaore]

Looks like we have one ticket with two issues. The original issue is still present in master, here's a snippet to test:

PDF = require 'pdfkit'
doc = new PDF
doc.text 'hello world', 2078, 10 # loops
doc.text 'hello world', doc.page.width-12, 10 # loops
doc.text 'hello world', doc.page.width-120, 10 # OK
doc.end()

[alafr]

@shimaore I confirm your issue is still there. I don't have time to fix it, but I will accept a pull request

[andreiaugustin]

Tested with:

const PDFDocument = require('..');
const fs = require('fs');

const doc = new PDFDocument();

doc.pipe(fs.createWriteStream('test.pdf'));

doc.text('hello world', 2078, 10); // loops
doc.text('hello world', doc.page.width-12, 10); // loops
doc.text('hello world', doc.page.width-120, 10); // OK

doc.end();

But I do not see an issue anymore in 0.18.0?

[blikblum]

Its an issue from CoffeScript days