From 2234ce97cf4a3a6450a91a48f4f7108daff33a28 Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Tue, 9 Jan 2024 16:39:27 -0800 Subject: [PATCH 1/3] print log links Signed-off-by: Kevin Su --- flytekit/extend/backend/base_agent.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/flytekit/extend/backend/base_agent.py b/flytekit/extend/backend/base_agent.py index e184cb88fb..cc7807a433 100644 --- a/flytekit/extend/backend/base_agent.py +++ b/flytekit/extend/backend/base_agent.py @@ -241,7 +241,9 @@ async def _get(self, resource_meta: bytes) -> GetTaskResponse: else: res = self._agent.get(grpc_ctx, resource_meta) state = res.resource.state - logger.info(f"Task state: {state}, State message: {res.resource.message}") + logger.info(f"Task state: {State.Name(state)}, State message: {res.resource.message}") + for link in res.resource.log_links: + progress.print(f"{link.name}: {link.uri}") return res def signal_handler(self, resource_meta: bytes, signum: int, frame: FrameType) -> typing.Any: From 711c7a6941e508f23ebc9be2ee8beeab534e2eb8 Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Wed, 10 Jan 2024 01:14:06 -0800 Subject: [PATCH 2/3] fix tests Signed-off-by: Kevin Su --- flytekit/extend/backend/base_agent.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/flytekit/extend/backend/base_agent.py b/flytekit/extend/backend/base_agent.py index cc7807a433..c5a137d520 100644 --- a/flytekit/extend/backend/base_agent.py +++ b/flytekit/extend/backend/base_agent.py @@ -242,8 +242,9 @@ async def _get(self, resource_meta: bytes) -> GetTaskResponse: res = self._agent.get(grpc_ctx, resource_meta) state = res.resource.state logger.info(f"Task state: {State.Name(state)}, State message: {res.resource.message}") - for link in res.resource.log_links: - progress.print(f"{link.name}: {link.uri}") + if hasattr(res.resource, "log_links"): + for link in res.resource.log_links: + progress.print(f"{link.name}: {link.uri}") return res def signal_handler(self, resource_meta: bytes, signum: int, frame: FrameType) -> typing.Any: From 1f8e377f695883362f664938fc31e40d6ceed091 Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Wed, 10 Jan 2024 02:09:33 -0800 Subject: [PATCH 3/3] nit Signed-off-by: Kevin Su --- flytekit/extend/backend/base_agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flytekit/extend/backend/base_agent.py b/flytekit/extend/backend/base_agent.py index c5a137d520..02c28287a1 100644 --- a/flytekit/extend/backend/base_agent.py +++ b/flytekit/extend/backend/base_agent.py @@ -241,7 +241,7 @@ async def _get(self, resource_meta: bytes) -> GetTaskResponse: else: res = self._agent.get(grpc_ctx, resource_meta) state = res.resource.state - logger.info(f"Task state: {State.Name(state)}, State message: {res.resource.message}") + progress.print(f"Task state: {State.Name(state)}, State message: {res.resource.message}") if hasattr(res.resource, "log_links"): for link in res.resource.log_links: progress.print(f"{link.name}: {link.uri}")