fix: improve code quality and fix identified bugs#47
Merged
Conversation
The function does not necessarily need to be in feeph/emc2101/pwm.py and we would like to perform additional refactoring to make the function shorter and easier to understand. This would add more functions to pwm.py which reduces readability and maintainability.
feeph
pushed a commit
that referenced
this pull request
Aug 14, 2024
## [0.2.2](v0.2.1...v0.2.2) (2024-08-14) ### Bug Fixes * fix error handling conditions for pin 6 configuration ([f525e67](f525e67)) * fix issues identified by newly added unit tests ([95b8e98](95b8e98)) * fix typo in variable name ([6501778](6501778)) * improve code quality and fix identified bugs ([c713556](c713556)) * improve code quality and fix identified bugs ([#47](#47)) ([c713556](c713556)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.