bump RTC-Folly to 2021.07.22#33841
Closed
luissantana wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Base commit: e5c5dcd |
Contributor
|
@genkikondo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@genkikondo what needs to happen to backport this change into v 0.65? thanks! |
Contributor
|
Just a heads up that this PR is sadly not enough to bump Folly. There are a variety of places where the Folly version is specified, specifically: Aside from iOS, also the Android bump will have to be done, as we want to make sure the two platform have aligned versions of Folly.
I think it's unlikely we backport this down to .65 as it would require a point release for .65, .66, .67 and .68. |
Contributor
Author
|
OMG, that is in fact sad news. |
Contributor
Author
|
hey @cortinico , I updated the remaining files with the version bump. hopefully that would be enough to upgrade in the current version. thanks! |
Contributor
|
Thanks for the heads up @luissantana. Can I ask you to rebase as the CI should be green now? |
luissantana
force-pushed
the
bump-rtc-folly
branch
from
3bd7636 to
d0b5492
Compare
Contributor
Author
|
@cortinico rebased :D |
Base commit: e5c5dcd |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Is there going to be an official release? |
Contributor
|
Just a small heads up. This is failing internally when building RN Tester with: Not sure why this is not failing on CircleCI though. Does it ring any bell? |
luissantana
force-pushed
the
bump-rtc-folly
branch
from
d0b5492 to
9ee7e21
Compare
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Thanks for re-running pod install @luissantana 👍 This solved the build issue. |
Collaborator
|
This pull request was successfully merged by @luissantana in 68f3a42. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumping RTC-Folly version used to address CVE-2022-24440.
Changelog
[General][Security] - Bump RTC-Folly to 2021-07-22
Test Plan