From edd4331aa91fa9800fc25a84e4c8a35c203963b3 Mon Sep 17 00:00:00 2001 From: Tanner Gooding Date: Mon, 12 Aug 2024 12:01:21 -0700 Subject: [PATCH 1/2] Add missing xml docs for System.Numerics --- .../src/System/Numerics/TotalOrderIeee754Comparer.cs | 5 +++++ .../System.Runtime.Numerics/src/System/Numerics/Complex.cs | 1 + 2 files changed, 6 insertions(+) diff --git a/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs b/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs index 77c33c4e04dceb..99fc3ad477c4aa 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs @@ -226,8 +226,13 @@ public int GetHashCode([DisallowNull] T obj) public bool Equals(TotalOrderIeee754Comparer other) => true; + /// Returns a value that indicates whether this instance and a specified object are equal. + /// The object to compare with the current instance. + /// true if the current instance and are equal; otherwise, false. If is null, the method returns false. public override bool Equals([NotNullWhen(true)] object? obj) => obj is TotalOrderIeee754Comparer; + /// Returns the hash code for this instance. + /// The hash code. public override int GetHashCode() => EqualityComparer.Default.GetHashCode(); } } diff --git a/src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs b/src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs index 51d0580c285edd..e162bab1738051 100644 --- a/src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs +++ b/src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs @@ -2200,6 +2200,7 @@ public static bool TryParse([NotNullWhen(true)] string? s, NumberStyles style, I public bool TryFormat(Span destination, out int charsWritten, [StringSyntax(StringSyntaxAttribute.NumericFormat)] ReadOnlySpan format = default, IFormatProvider? provider = null) => TryFormatCore(destination, out charsWritten, format, provider); + /// public bool TryFormat(Span utf8Destination, out int bytesWritten, [StringSyntax(StringSyntaxAttribute.NumericFormat)] ReadOnlySpan format = default, IFormatProvider? provider = null) => TryFormatCore(utf8Destination, out bytesWritten, format, provider); From 8f95cb4740f3e00135ba75d0fc2815eeeca1765e Mon Sep 17 00:00:00 2001 From: Tanner Gooding Date: Tue, 13 Aug 2024 11:05:26 -0700 Subject: [PATCH 2/2] Update src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- .../src/System/Numerics/TotalOrderIeee754Comparer.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs b/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs index 99fc3ad477c4aa..dca39f67536041 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs @@ -226,7 +226,7 @@ public int GetHashCode([DisallowNull] T obj) public bool Equals(TotalOrderIeee754Comparer other) => true; - /// Returns a value that indicates whether this instance and a specified object are equal. + /// Determines whether this instance and a specified object are equal. /// The object to compare with the current instance. /// true if the current instance and are equal; otherwise, false. If is null, the method returns false. public override bool Equals([NotNullWhen(true)] object? obj) => obj is TotalOrderIeee754Comparer;