From b87b891b28eee6a2707f2e399e6bf6a7721a4008 Mon Sep 17 00:00:00 2001 From: Petr Date: Mon, 31 Mar 2025 13:06:37 +0200 Subject: [PATCH 1/4] Fix a copypaste checking bug in pickling --- src/Compiler/TypedTree/TypedTreePickle.fs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Compiler/TypedTree/TypedTreePickle.fs b/src/Compiler/TypedTree/TypedTreePickle.fs index 9515d49b80d..50e3ebff857 100644 --- a/src/Compiler/TypedTree/TypedTreePickle.fs +++ b/src/Compiler/TypedTree/TypedTreePickle.fs @@ -864,7 +864,7 @@ let unpickleObjWithDanglingCcus file viewedScope (ilModule: ILModuleDef option) iILModule = ilModule } let res = u st1 check viewedScope st1.ientities - check viewedScope st1.ientities + check viewedScope st1.ianoninfos check viewedScope st1.ivals check viewedScope st1.itypars res From a3aeaf744ae5f82d46b1fdf1075e62cbbcf20a9c Mon Sep 17 00:00:00 2001 From: Petr Date: Mon, 31 Mar 2025 14:40:58 +0200 Subject: [PATCH 2/4] rn --- docs/release-notes/.FSharp.Compiler.Service/9.0.200.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md index 8bfd9d8155b..2a4ab5c44c0 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md +++ b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md @@ -21,6 +21,7 @@ * Completion: fix qualified completion in sequence expressions [PR #18111](https://github.com/dotnet/fsharp/pull/18111) * Symbols: try to use ValReprInfoForDisplay in Mfv.CurriedParameterGroups ([PR #18124](https://github.com/dotnet/fsharp/pull/18124)) * Shim/file system: fix leaks of the shim [PR #18144](https://github.com/dotnet/fsharp/pull/18144) +* Fix checking bug in unpickling [PR #18430](https://github.com/dotnet/fsharp/pull/18430) ### Added @@ -55,4 +56,4 @@ ### Breaking Changes -* Aliasing `StructAttribute` will now produce a warning (part of [Language suggestion #1136](https://github.com/fsharp/fslang-suggestions/issues/1136), [PR #18098](https://github.com/dotnet/fsharp/pull/18098)) \ No newline at end of file +* Aliasing `StructAttribute` will now produce a warning (part of [Language suggestion #1136](https://github.com/fsharp/fslang-suggestions/issues/1136), [PR #18098](https://github.com/dotnet/fsharp/pull/18098)) From 9852fd656160be79c340d34dcb24a713b9f04101 Mon Sep 17 00:00:00 2001 From: Petr Date: Mon, 31 Mar 2025 14:49:47 +0200 Subject: [PATCH 3/4] up --- docs/release-notes/.FSharp.Compiler.Service/9.0.200.md | 2 +- docs/release-notes/.FSharp.Compiler.Service/9.0.300.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md index 98de0459d67..85c7cb6f94d 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md +++ b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md @@ -24,7 +24,7 @@ * Shim/file system: fix leaks of the shim [PR #18144](https://github.com/dotnet/fsharp/pull/18144) * fsi: fix auto-loading of script file inside NuGet package ([PR #18177](https://github.com/dotnet/fsharp/pull/18177)) * Fix for `Obsolete` attribute warning/error not taken into account when used with a unit of measure [PR #18182](https://github.com/dotnet/fsharp/pull/18182) -* Fix checking bug in unpickling [PR #18430](https://github.com/dotnet/fsharp/pull/18430) + ### Added diff --git a/docs/release-notes/.FSharp.Compiler.Service/9.0.300.md b/docs/release-notes/.FSharp.Compiler.Service/9.0.300.md index f40ab0428ed..9f22a730d3e 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/9.0.300.md +++ b/docs/release-notes/.FSharp.Compiler.Service/9.0.300.md @@ -20,6 +20,8 @@ * Fix duplicate parse error reporting for GetBackgroundCheckResultsForFileInProject ([Issue #18379](https://github.com/dotnet/fsharp/issues/18379) [PR #18380](https://github.com/dotnet/fsharp/pull/18380)) * Fix MethodDefNotFound when compiling code invoking delegate with option parameter ([Issue #5171](https://github.com/dotnet/fsharp/issues/5171), [PR #18385](https://github.com/dotnet/fsharp/pull/18385)) * Fix #r nuget ..." downloads unneeded packages ([Issue #18231](https://github.com/dotnet/fsharp/issues/18231), [PR #18393](https://github.com/dotnet/fsharp/pull/18393)) +* Fix checking bug in unpickling [PR #18430](https://github.com/dotnet/fsharp/pull/18430) + ### Added * Added missing type constraints in FCS. ([PR #18241](https://github.com/dotnet/fsharp/pull/18241)) From 3a129a76ee1d27e8905f0afeb8f743159472b028 Mon Sep 17 00:00:00 2001 From: Petr Date: Mon, 31 Mar 2025 14:50:02 +0200 Subject: [PATCH 4/4] Update 9.0.200.md --- docs/release-notes/.FSharp.Compiler.Service/9.0.200.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md index 85c7cb6f94d..0a05f20bf45 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md +++ b/docs/release-notes/.FSharp.Compiler.Service/9.0.200.md @@ -25,7 +25,6 @@ * fsi: fix auto-loading of script file inside NuGet package ([PR #18177](https://github.com/dotnet/fsharp/pull/18177)) * Fix for `Obsolete` attribute warning/error not taken into account when used with a unit of measure [PR #18182](https://github.com/dotnet/fsharp/pull/18182) - ### Added * Let `dotnet fsi --help` print a link to the documentation website. ([PR #18006](https://github.com/dotnet/fsharp/pull/18006))