From b91c6056c10607e386837fc6cf6ab92c0d649445 Mon Sep 17 00:00:00 2001
From: Buyaa Namnan <bunamnan@microsoft.com>
Date: Mon, 18 Sep 2023 11:50:11 -0700
Subject: [PATCH] Add remaining missing docs in reflection emit

---
 xml/System.Reflection.Emit/EnumBuilder.xml    | 19 +++++++++++--
 .../GenericTypeParameterBuilder.xml           | 27 ++++++++++++++-----
 xml/System.Reflection.Emit/ILGenerator.xml    |  4 +--
 xml/System.Reflection.Emit/TypeBuilder.xml    | 11 ++++++++
 4 files changed, 51 insertions(+), 10 deletions(-)

diff --git a/xml/System.Reflection.Emit/EnumBuilder.xml b/xml/System.Reflection.Emit/EnumBuilder.xml
index 1d111d91718..112ddced72b 100644
--- a/xml/System.Reflection.Emit/EnumBuilder.xml
+++ b/xml/System.Reflection.Emit/EnumBuilder.xml
@@ -281,6 +281,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="BaseType">
@@ -869,6 +870,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetConstructorImpl">
@@ -937,6 +939,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetConstructors">
@@ -1932,6 +1935,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetMethods">
@@ -2239,9 +2243,10 @@
         <param name="returnType">To be added.</param>
         <param name="types">To be added.</param>
         <param name="modifiers">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Calling this method always throws <see cref="T:System.NotSupportedException" />.</summary>
+        <returns>This method is not supported. No value is returned.</returns>
         <remarks>To be added.</remarks>
+        <exception cref="T:System.NotSupportedException">This method is not currently supported.</exception>
       </Docs>
     </Member>
     <Member MemberName="GUID">
@@ -2332,6 +2337,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="InvokeMember">
@@ -2460,6 +2466,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsAssignableFrom">
@@ -2550,6 +2557,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsByRefLike">
@@ -2580,6 +2588,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsCOMObjectImpl">
@@ -2619,6 +2628,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsConstructedGenericType">
@@ -2856,6 +2866,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsPrimitiveImpl">
@@ -2895,6 +2906,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsSerializable">
@@ -2953,6 +2965,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsTypeDefinition">
@@ -2984,6 +2997,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsValueTypeImpl">
@@ -3023,6 +3037,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsVariableBoundArray">
diff --git a/xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml b/xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml
index 422d3e07502..2f8be4a8b3d 100644
--- a/xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml
+++ b/xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml
@@ -235,6 +235,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="BaseType">
@@ -724,6 +725,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetConstructorImpl">
@@ -791,9 +793,10 @@
         <param name="callConvention">To be added.</param>
         <param name="types">To be added.</param>
         <param name="modifiers">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Not supported for incomplete generic type parameters.</summary>
+        <returns>Not supported for incomplete generic type parameters.</returns>
         <remarks>To be added.</remarks>
+        <exception cref="T:System.NotSupportedException">In all cases.</exception>
       </Docs>
     </Member>
     <Member MemberName="GetConstructors">
@@ -1828,9 +1831,10 @@
         <param name="callConvention">To be added.</param>
         <param name="types">To be added.</param>
         <param name="modifiers">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Not supported for incomplete generic type parameters.</summary>
+        <returns>Not supported for incomplete generic type parameters.</returns>
         <remarks>To be added.</remarks>
+        <exception cref="T:System.NotSupportedException">In all cases.</exception>
       </Docs>
     </Member>
     <Member MemberName="GetMethods">
@@ -2126,9 +2130,10 @@
         <param name="returnType">To be added.</param>
         <param name="types">To be added.</param>
         <param name="modifiers">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Not supported for incomplete generic type parameters.</summary>
+        <returns>Not supported for incomplete generic type parameters.</returns>
         <remarks>To be added.</remarks>
+        <exception cref="T:System.NotSupportedException">In all cases.</exception>
       </Docs>
     </Member>
     <Member MemberName="GUID">
@@ -2213,6 +2218,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="InvokeMember">
@@ -2339,6 +2345,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <MemberGroup MemberName="IsAssignableFrom">
@@ -2507,6 +2514,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsByRefLike">
@@ -2537,6 +2545,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsCOMObjectImpl">
@@ -2575,6 +2584,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsConstructedGenericType">
@@ -2890,6 +2900,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsPrimitiveImpl">
@@ -2928,6 +2939,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsSerializable">
@@ -3042,6 +3054,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsTypeDefinition">
@@ -3073,6 +3086,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsValueTypeImpl">
@@ -3111,6 +3125,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsVariableBoundArray">
diff --git a/xml/System.Reflection.Emit/ILGenerator.xml b/xml/System.Reflection.Emit/ILGenerator.xml
index f2ed8263921..c417272a8fb 100644
--- a/xml/System.Reflection.Emit/ILGenerator.xml
+++ b/xml/System.Reflection.Emit/ILGenerator.xml
@@ -103,8 +103,8 @@
       </AssemblyInfo>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
-        <remarks>To be added.</remarks>
+        <summary>Initializes a new instance of the <see cref="T:System.Reflection.Emit.ILGenerator" /> class.</summary>
+        <remarks>This constructor is invoked by derived classes.</remarks>
       </Docs>
     </Member>
     <Member MemberName="BeginCatchBlock">
diff --git a/xml/System.Reflection.Emit/TypeBuilder.xml b/xml/System.Reflection.Emit/TypeBuilder.xml
index decb874b87d..409f28071c2 100644
--- a/xml/System.Reflection.Emit/TypeBuilder.xml
+++ b/xml/System.Reflection.Emit/TypeBuilder.xml
@@ -4539,6 +4539,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetConstructor">
@@ -4688,6 +4689,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetConstructors">
@@ -5880,6 +5882,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GetMethods">
@@ -6194,6 +6197,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="GUID">
@@ -6280,6 +6284,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="InvokeMember">
@@ -6415,6 +6420,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <MemberGroup MemberName="IsAssignableFrom">
@@ -6571,6 +6577,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsByRefLike">
@@ -6601,6 +6608,7 @@
         <summary>To be added.</summary>
         <value>To be added.</value>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsCOMObjectImpl">
@@ -6640,6 +6648,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsConstructedGenericType">
@@ -7033,6 +7042,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsPrimitiveImpl">
@@ -7072,6 +7082,7 @@
         <summary>To be added.</summary>
         <returns>To be added.</returns>
         <remarks>To be added.</remarks>
+        <inheritdoc />
       </Docs>
     </Member>
     <Member MemberName="IsSecurityCritical">
