docker commit should not drop configuration

[mhennings]

Currently when doing a commit on a container to update an image, the configuration the image had is not kept.

I think there should be an option to drop the previous config and a default to keep it.

[fkautz]

What configuration are you thinking of?

E.g. dns? mounted volumes?

[mhennings]

i had volumes and the cmd in mind.

[asbjornenge]

👍 this hit me hard today :-/ Built up quite a huge Dockerfile with lots of ports EXPOSEd. If I do some work in the container and want to commit as a new image, all ports and also CMD is lost.

[jpetazzo]

+1

On Fri, Sep 13, 2013 at 9:55 AM, asbjornenge notifications@github.comwrote:

[image: 👍] this hit me hard today :-/ Built up quite a huge Dockerfile
with lots of ports EXPOSEd. If I do some work in the container and want to
commit as a new image, all ports and also CMD is lost.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1141#issuecomment-24408559
.

@jpetazzo https://twitter.com/jpetazzo
Latest blog post: http://blog.docker.io/2013/09/docker-joyent-openvpn-bliss/

[taylortrimble]

This was a big one for me today as well!

[asbjornenge]

A friendly tip (might be obvious to most):

As a workaround I just keep a separate Dockerfile with only the configuration stuff that is lost, and the image I'm committing to as FROM. It's not awesome, but it works.

[taylortrimble]

Haha! A dirty hack, but I will use it 'til we see this closed!

Thanks. :)

[vampolo]

+1

[icook]

+1

[athieriot]

+1

[BMorearty]

+1

In addition, docker history imagename should show the configuration overrides that were passed via the -run option to docker commit. So you can see the run configuration.

I know you can do docker inspect imagename but that's all the configuration, not just the overrides from the command line. It's hard to see what the deltas are.

[creack]

ping @shykes, any thoughts?

[parente]

+1 on preserving cmd, ports, env, etc.

[shykes]

I believe this has been fixed, @creack @crosbymichael @vieux can you confirm?