docker 1.8+ no longer needs dind#15596
Conversation
|
hmm weird errors... need to investigate why... |
|
the windows side is because i need to update those servers |
|
Is this still needed? https://github.com/docker/docker/blob/master/hack/dind#L14 |
|
Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed. IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, |
|
nice yeah On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi notifications@github.com
|
Signed-off-by: Jessica Frazelle <acidburn@docker.com>
8145137 to
c48ac77
Compare
|
LGTM 🤘 |
|
(much easier to review via https://github.com/docker/docker/pull/15596/files?w=1 now) |
docker 1.8+ no longer needs dind
ping @tianon idk what to make the entrypoint tbh or if you think this is too soon ;)