From 1bfc1185abdc0b819ef63061ced37d4b8c68ab29 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Mon, 18 May 2026 04:12:10 -0500 Subject: [PATCH] fix(ci): upload desktop artifacts via softprops/action-gh-release MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit electron-builder's GitHub publish provider skips uploads when the release type doesn't match its expected "draft" type. release-please creates releases as prerelease (non-draft), causing the mismatch. Fix by removing the github provider from electron-builder.yml (keeping only the generic provider for dl.devsy.sh auto-update) and adding an explicit softprops/action-gh-release step to upload desktop artifacts (.dmg, .zip, .exe, .AppImage, .deb, .rpm) directly to the GitHub release — the same approach used by CLI binary and Flatpak uploads. --- .github/workflows/release.yml | 13 +++++++++++++ desktop/electron-builder.yml | 3 --- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d46bc28ad..d8a3a866e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -183,6 +183,19 @@ jobs: env: GH_TOKEN: ${{ github.token }} + - name: upload desktop artifacts to release + uses: softprops/action-gh-release@v3 + with: + tag_name: ${{ inputs.tag || github.ref_name }} + draft: true + files: | + desktop/release/*.dmg + desktop/release/*.zip + desktop/release/*.exe + desktop/release/*.AppImage + desktop/release/*.deb + desktop/release/*.rpm + - name: upload update metadata artifact uses: actions/upload-artifact@v7 with: diff --git a/desktop/electron-builder.yml b/desktop/electron-builder.yml index ccf78dc45..4a07f3f1c 100644 --- a/desktop/electron-builder.yml +++ b/desktop/electron-builder.yml @@ -98,6 +98,3 @@ publish: - provider: generic url: https://dl.devsy.sh/desktop useMultipleRangeRequest: false - - provider: github - owner: devsy-org - repo: devsy