From 17402cdcbe61d83784b69242cd51e55879e1db8e Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sun, 17 May 2026 17:37:18 -0500 Subject: [PATCH] fix(ci): pin Windows desktop build runner to windows-2022 windows-latest now ships VS 2026 (v18) which node-gyp doesn't recognize, breaking electron-rebuild for node-pty. Pin to windows-2022 (VS 2022 / v17) and remove the vswhere GYP_MSVS_OVERRIDE_PATH workaround that is no longer needed. --- .github/workflows/release.yml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ffadef17e..17f72062b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,7 +66,7 @@ jobs: go-os: darwin go-arch: universal builder-args: --mac - - os: windows-latest + - os: windows-2022 go-os: windows go-arch: amd64 builder-args: --win @@ -142,14 +142,6 @@ jobs: PARTIAL: "true" run: go run ./main.go ${{ inputs.tag || github.ref_name }} ../../dist > ../../dist/provider.yaml - - name: configure Windows build tools - if: runner.os == 'Windows' - shell: pwsh - run: | - echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV - $vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath - echo "GYP_MSVS_OVERRIDE_PATH=$vsPath" >> $env:GITHUB_ENV - - uses: actions/setup-python@v6 with: python-version: "3.12"