From a552e01a9b5cf3c77046e136b2d8f76dffafd79e Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sun, 17 May 2026 13:10:03 -0500 Subject: [PATCH] fix(ci): resolve 3 desktop build failures in release workflow - Point generate-pro-provider base_path to dist/ where arch-suffixed binaries are staged, and add PARTIAL=true as a safety net for any missing platform binaries - Add electron-vite build step before electron-builder so dist/main/index.js exists when packaging - Pin VS installation path via GYP_MSVS_OVERRIDE_PATH to prevent node-gyp stdout maxBuffer overflow during VS enumeration on Windows --- .github/workflows/release.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 79f648abe..eb2e0996e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -131,12 +131,17 @@ jobs: - name: generate pro provider if: runner.os == 'Linux' working-directory: ./hack/pro - run: go run ./main.go ${{ inputs.tag || github.ref_name }} ../../desktop/resources/bin > ../../dist/provider.yaml + env: + PARTIAL: "true" + run: go run ./main.go ${{ inputs.tag || github.ref_name }} ../../dist > ../../dist/provider.yaml - name: configure Windows build tools if: runner.os == 'Windows' shell: pwsh - run: echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV + run: | + echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV + $vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath + echo "GYP_MSVS_OVERRIDE_PATH=$vsPath" >> $env:GITHUB_ENV - uses: actions/setup-python@v6 with: @@ -161,6 +166,10 @@ jobs: if: runner.os == 'Linux' run: sudo apt-get update && sudo apt-get install -y xvfb + - name: build desktop app + working-directory: desktop + run: npx electron-vite build + - name: package and publish with electron-builder working-directory: desktop run: npx electron-builder ${{ matrix.builder-args }} --publish always --config electron-builder.yml