From 84999d05fdffcb8f9d99e42ca0ddebbb6381b5f6 Mon Sep 17 00:00:00 2001 From: shenxianpeng Date: Sun, 4 Feb 2024 04:45:40 +0000 Subject: [PATCH 1/4] docs: state what python version is used in README --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 62388954..590ffd36 100644 --- a/README.md +++ b/README.md @@ -34,6 +34,9 @@ Create a new GitHub Actions workflow in your project, e.g. at [.github/workflows The content of the file should be in the following format. +> [!WARNING] +> Python 3.10 needs to be installed in the docker image if your workflows use docker images not maintained by GitHub ([#185](https://github.com/cpp-linter/cpp-linter-action/issues/185)). + ```yaml name: cpp-linter From 55fca68586f45728357055dd196103785a39a45d Mon Sep 17 00:00:00 2001 From: shenxianpeng Date: Sun, 4 Feb 2024 04:49:41 +0000 Subject: [PATCH 2/4] docs: state what python version is used in README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 590ffd36..ec859887 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ Create a new GitHub Actions workflow in your project, e.g. at [.github/workflows The content of the file should be in the following format. -> [!WARNING] +> [!NOTE] > Python 3.10 needs to be installed in the docker image if your workflows use docker images not maintained by GitHub ([#185](https://github.com/cpp-linter/cpp-linter-action/issues/185)). ```yaml From a6c97b9f93f21176240dde5ec9d7894c4eca76ad Mon Sep 17 00:00:00 2001 From: Peter Shen Date: Sun, 4 Feb 2024 14:47:59 +0800 Subject: [PATCH 3/4] Update README.md Co-authored-by: Brendan <2bndy5@gmail.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ec859887..884a9c0c 100644 --- a/README.md +++ b/README.md @@ -36,7 +36,7 @@ The content of the file should be in the following format. > [!NOTE] > Python 3.10 needs to be installed in the docker image if your workflows use docker images not maintained by GitHub ([#185](https://github.com/cpp-linter/cpp-linter-action/issues/185)). - +Our intention is to synchronize with the default python version included with Ubuntu latest LTS releases. ```yaml name: cpp-linter From 79ba051f5de6da8415d000d722d46f32e2bdd74a Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Sat, 3 Feb 2024 23:19:56 -0800 Subject: [PATCH 4/4] review changes --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 884a9c0c..1c3c6209 100644 --- a/README.md +++ b/README.md @@ -30,13 +30,16 @@ Refer [here](https://github.com/cpp-linter/cpp-linter-action/tree/v1) for previo ## Usage +> [!NOTE] +> Python 3.10 needs to be installed in the docker image if your workflow is +> [running jobs in a container](https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container) +> (see discussion in [#185](https://github.com/cpp-linter/cpp-linter-action/issues/185)). +> Our intention is to synchronize with the default python version included with Ubuntu latest LTS releases. + Create a new GitHub Actions workflow in your project, e.g. at [.github/workflows/cpp-linter.yml](https://github.com/cpp-linter/cpp-linter-action/blob/main/.github/workflows/cpp-linter.yml) The content of the file should be in the following format. -> [!NOTE] -> Python 3.10 needs to be installed in the docker image if your workflows use docker images not maintained by GitHub ([#185](https://github.com/cpp-linter/cpp-linter-action/issues/185)). -Our intention is to synchronize with the default python version included with Ubuntu latest LTS releases. ```yaml name: cpp-linter