feat: quality gate — threshold-based pass/fail for CI (#205)#227
Merged
Conversation
Implements configurable quality gate that evaluates review findings
against thresholds to produce a definitive PASS/FAIL result.
Features:
- Global thresholds: max_critical, max_major, max_minor, max_security
- Per-category overrides: block, warn, ignore actions
- Terminal-formatted gate output with status table
- Exit code 2 (blocked) on gate failure
- Config via .cora.yaml under quality_gate section
- 12 unit tests covering all gate scenarios
Example .cora.yaml:
quality_gate:
enabled: true
thresholds:
max_critical: 0
max_security: 0
categories:
performance:
action: warn
max_findings: 5
Closes #205 (partial — baseline support deferred)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements configurable quality gate for CI enforcement. Closes #205 (partial).
New
src/engine/quality_gate.rs— gate evaluation logic (558 lines).cora.yamlunderquality_gatesectionConfig Example
Output
Test Results