Skip to content

Add overload for supplying Color to PngByteQRCode.GetGraphic#564

Merged
codebude merged 3 commits intomasterfrom
overload_for_color
Jun 20, 2024
Merged

Add overload for supplying Color to PngByteQRCode.GetGraphic#564
codebude merged 3 commits intomasterfrom
overload_for_color

Conversation

@Shane32
Copy link
Owner

@Shane32 Shane32 commented Jun 11, 2024

Summary

This PR adds an overload to PngByteQRCode.GetGraphic that accepts System.Drawing.Color instances, which are available on all supported platforms except .NET Standard 1.3

Test plan

Test added

Closing issues

Addresses confusion here: #536 (comment)

@Shane32 Shane32 changed the title Add overload for color to PngByteQRCode Add overload for supplying Color to PngByteQRCode.GetGraphic Jun 11, 2024
@codebude
Copy link
Collaborator

@codebude
Copy link
Collaborator

@codebude
Copy link
Collaborator

@Shane32 Can you have a look on the merge conflict?

@codebude codebude merged commit 81fad40 into Shane32:master Jun 20, 2024
@Shane32 Shane32 added this to the 1.6.0 milestone Oct 8, 2025
@Shane32 Shane32 added the enhancement A new feature or feature request label Oct 8, 2025
vaernion pushed a commit to Arbeidstilsynet/brevgen2 that referenced this pull request Dec 3, 2025
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [QRCoder](https://github.com/codebude/QRCoder) | `1.4.3` -> `1.6.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/QRCoder/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/QRCoder/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/QRCoder/1.4.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/QRCoder/1.4.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>codebude/QRCoder (QRCoder)</summary>

### [`v1.6.0`](https://github.com/codebude/QRCoder/releases/tag/v1.6.0)

#### What has changed

-   \[Enhancement] Huge performance (runtime and memory) optimization in `QrCodeGenerator` (PRs [#&#8203;509](Shane32/QRCoder#509), [#&#8203;519](Shane32/QRCoder#519), [#&#8203;520](Shane32/QRCoder#520), [#&#8203;521](Shane32/QRCoder#521), [#&#8203;524](Shane32/QRCoder#524), [#&#8203;530](Shane32/QRCoder#530), [#&#8203;532](Shane32/QRCoder#532))
-   \[Enhancement] Big performance (runtime and memory) optimization in `BitmapByteQRCode` (PR [#&#8203;566](Shane32/QRCoder#566))
-   \[Enhancement] Added ECC level mismatch detection when using payloads from payload generator (PR [#&#8203;526](Shane32/QRCoder#526))
-   \[Enhancement] Implementation of encoding constraints (EccLevel, EciMode) in SwissQRCode and GiroCode payloads to enforce that the payloads comply with the specifications of the respective standards (PR [#&#8203;533](Shane32/QRCoder#533))
-   \[Enhancement] Added support for trimming (`IsTrimmable` project property) (PR [#&#8203;539](Shane32/QRCoder#539))
-   \[Enhancement] Added XML comments (code documentation) to all public members (PR [#&#8203;561](Shane32/QRCoder#561))
-   \[Enhancement] Added new/third overload to `PngByteQRCode` that accepts colors as System.Drawing.Color (PR [#&#8203;564](Shane32/QRCoder#564))
-   \[Enhancement] Updated the Bitmap header from BITMAPCOREHEADER to BITMAPINFOHEADER in `BitmapByteQRCode` (PR [#&#8203;565](Shane32/QRCoder#565))
-   \[Refactoring] Restructured `QRCodeGenerator` classes into separate files and partially restructured code for better manageability (PRs [#&#8203;516](Shane32/QRCoder#516), [#&#8203;528](Shane32/QRCoder#528), [#&#8203;531](https://github....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A new feature or feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants