-
Notifications
You must be signed in to change notification settings - Fork 463
Description
Revert stable version of ViewPager on Android (version v4.2.0) (@troZee)
In the 4.x.x version, native implementation of ViewPager has been updated to a higher version, which is V2. V2 version uses another implementation (Recycler View) than V1. Community noticed lots of issues in the V2 version, hence I would like to revert viewpager to V1 and create a separate branch for V2.
action items:
- update a readme
- describe a breaking changes
- create a PR
- setup a npm next and latest tags (latest4.2.0 next: 5.x.x)
Create a separate workspaces for lib and example: (no version affected) (@troZee )
Each library repository should provide an example of library usage. This example should cover a common use cases. In the ViewPager example, I would like to add some dependencies like react-navigation, to be able to test ViewPager with other libs.
Example of separate workspaces: callstack/react-native-slider@5220303
action items:
- create a PR
- setup a npm
Add more examples: (no version affected)
People use VP in various cases. Currently the library provides only one simple case, hence it is hard to reproduce some issues.
Example cases:
VP inside FlatList
FlatList inside VP
more and more
If you would like to add an example to lib, don't hesitate and please reach me out in this ticket.
Add known issues section to README file (no version affected) (everyone can take it)
Known issues:
flex:1does not work, usewidth:”100%”, height:”100%”instead
-Android rendering children of View as separate pages #186 (comment)
[iOS]: In case of UIViewControllerHierarchyInconsistency error, please use below fix:
requestAnimationFrame(() => refViewPager.current?.setPage(index));
E2E tests: (no version affected) (optional)
This library is purely native. JS part is only responsible for exposing view and methods, which can be used inside React components. I would like to cover some cases, which I did for each PR (swiping between each page, deleting each page)