Refresh lock unit testing (via miniredis)#90
Closed
iSerganov wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@dim, as agreed sending you |
Member
|
I think it only makes sense to switch to miniredis if we update all our tests to it. It's a bit strange to have part of it still using the real server. |
Member
|
How do you feel about #91? |
Contributor
Author
Yep, that's a good idea! Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The new
miniredistest pack covers ~18 cases cheaply with no external dependency (multi-key, nil receiver, value preservation, ctx-cancelled-mid-retry, spy-verified NextBackoff call counts) — that breadth would be painful to replicate against real Redis. Whereas the existing tests inredislock_test.gocover only ~6 scenarios and verify the actual Lua scripts run correctly against real Redis. So IMHO, this looks like a good addition to existing test cases.