Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Adds Native.make_error(message) and refactors functions handler#15

Merged
edward merged 1 commit intosass:masterfrom
edward:use-actual-error-function
Jul 13, 2015
Merged

Adds Native.make_error(message) and refactors functions handler#15
edward merged 1 commit intosass:masterfrom
edward:use-actual-error-function

Conversation

@edward
Copy link
Copy Markdown
Member

@edward edward commented Jul 13, 2015

For review @bolandrm

@bolandrm
Copy link
Copy Markdown
Member

👍 gave you commit access. feel free to merge when rebased.

I'd still prefer if you open PRs so I can review, just so I can see how the code is changing.

@edward edward force-pushed the use-actual-error-function branch from 45dfec3 to 5d4ca17 Compare July 13, 2015 18:58
@edward
Copy link
Copy Markdown
Member Author

edward commented Jul 13, 2015

@bolandrm I am humbled 👯

Thanks!

@edward
Copy link
Copy Markdown
Member Author

edward commented Jul 13, 2015

Also: sounds good – I prefer the code review anyway :)

(At Shopify there are usually 2+ reviewers to any code change and they all happen in regular PRs.)

edward pushed a commit that referenced this pull request Jul 13, 2015
Adds Native.make_error(message) and refactors functions handler
@edward edward merged commit 93735f1 into sass:master Jul 13, 2015
@edward edward deleted the use-actual-error-function branch July 13, 2015 19:01
michael-gillett pushed a commit to michael-gillett/sassc-ruby that referenced this pull request Apr 25, 2019
Act-439: rely on go_links_db models
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants